-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid CSS parcing error in @keyframes rule #8052
Comments
Not actually a "release candidate". It is the latest released NetBeans 24. The form just did not have this option. |
Sorry, I'll look into this. |
Before 23ed111 "CSS: Improve handling of generic-at-rules (for example used by tailwind)" the CSS parser returned the body of generic @-rules as a plain list of tokens. That changed and the @Keyframes rule needs to be special cased. There was already a special case for the @-webkit-keyframes variant, which is identical to the final variant and differs only in the introducing rule name. Closes: apache#8052
@vbickov from the checks page of #8053 a nightly build available checks page direct link. It would be great if you could test it. For NB 23, you might succeed by replacing the existing |
@matthiasblaesing The org-netbeans-modules-css-lib.jar from the nightly build solves the issue for NB 24. I do not have NB 23 anymore and never experienced this issue with NB 23. Thank you. |
@matthiasblaesing Apparently, I was wrong. After I replaced org-netbeans-modules-css-lib.jar from the nightly build, it seemed that the issue was solved. However, after a couple of seconds, the error came back. I also tried to replace all JARs with CSS in their names. Am I missing something? |
Please ensure that you delete the cache dir. Under windows the two relevant paths are (the first can be safely deleted):
Please don't close the issue, it will be automatically closed once the fix is merged to master. |
@matthiasblaesing Thank you. Removing the cache dir helps. |
@vbickov I pushed another update. The |
@matthiasblaesing thank you. I was just about to report the issue with @-moz-keyframes The update you provided fixes issue with @-moz-keyframes |
Before 23ed111 "CSS: Improve handling of generic-at-rules (for example used by tailwind)" the CSS parser returned the body of generic @-rules as a plain list of tokens. That changed and the @Keyframes rule needs to be special cased. There was already a special case for the @-webkit-keyframes variant, which is identical to the final variant and differs only in the introducing rule name. The vendored variants @-moz-keyframes and @-o-keyframes are also supported. Closes: apache#8052
Hello. My first time here trying to contribute... I know it's a closed issue but after applying the fix, I found a couple of errors in my project related to keyframes and viewport, both for ms versions: @-ms-keyframes --> Used in my own CSS files (to ensure copatibility with old Miscrosoft browsers) It looks like they are missing or wrong in the css module, as I am getting similar errors to the previous ones mentioned here. |
Is there somewhere outside your own code an occurence of For @-ms-viewport. Nothing changed for that. It is "supported": The warning is correct, as |
Apache NetBeans version
Apache NetBeans 24 release candidate
What happened
NetBeans 24 considers the following CSS block as erroneous. It does not like "%0" and says that "Unexpected token PERCENTAGE" is found. If I configure the validator to ignore the error, it starts blaming the closing bracket. The code is obviously fine.
Language / Project Type / NetBeans Component
No response
How to reproduce
Just create a CSS file and put the code in there.
Did this work correctly in an earlier version?
Apache NetBeans 23
Operating System
Windows 11 Pro 24H2
JDK
Java HotSpot(TM) 64-Bit Server VM (build 23.0.1+11-39, mixed mode, sharing)
Apache NetBeans packaging
Apache NetBeans provided installer
Anything else
No response
Are you willing to submit a pull request?
No
The text was updated successfully, but these errors were encountered: