Skip to content

Commit 9e7e613

Browse files
author
Vincent Potucek
committed
[POC-FIX-PMD] maven-pmd-plugin: reactivate PMD
1 parent ffd30a3 commit 9e7e613

File tree

3 files changed

+130
-1
lines changed

3 files changed

+130
-1
lines changed

‎.gitignore

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,5 @@
1616
.factorypath
1717
.vscode/
1818
repo/
19-
/*.svg
19+
/*.svg
20+
/**/.cache

‎.pmd/exclude.properties

Lines changed: 94 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,94 @@
1+
# Licensed to the Apache Software Foundation (ASF) under one
2+
# or more contributor license agreements. See the NOTICE file
3+
# distributed with this work for additional information
4+
# regarding copyright ownership. The ASF licenses this file
5+
# to you under the Apache License, Version 2.0 (the
6+
# "License"); you may not use this file except in compliance
7+
# with the License. You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing,
12+
# software distributed under the License is distributed on an
13+
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
14+
# KIND, either express or implied. See the License for the
15+
# specific language governing permissions and limitations
16+
# under the License.
17+
# TODO rework justiciable
18+
org.apache.maven.api.JavaPathType=UnnecessaryModifier
19+
org.apache.maven.api.plugin.testing.MojoExtension=CollapsibleIfStatements
20+
org.apache.maven.api.plugin.testing.stubs.SessionMock=TooManyStaticImports
21+
org.apache.maven.artifact.deployer.DefaultArtifactDeployer=EmptyControlStatement
22+
org.apache.maven.artifact.handler.manager.DefaultArtifactHandlerManager=CollapsibleIfStatements
23+
org.apache.maven.artifact.handler.manager.LegacyArtifactHandlerManager=CollapsibleIfStatements
24+
org.apache.maven.artifact.installer.DefaultArtifactInstaller=EmptyControlStatement
25+
org.apache.maven.artifact.repository.DefaultArtifactRepository=UnusedFormalParameter
26+
org.apache.maven.artifact.repository.metadata.DefaultRepositoryMetadataManager=CollapsibleIfStatements
27+
org.apache.maven.artifact.resolver.DaemonThreadCreator=AvoidThreadGroup
28+
org.apache.maven.artifact.resolver.filter.ExclusionArtifactFilter=UnusedPrivateField
29+
org.apache.maven.artifact.versioning.VersionRange=CollapsibleIfStatements
30+
org.apache.maven.bridge.MavenRepositorySystem=AvoidUsingHardCodedIP
31+
org.apache.maven.cli.configuration.SettingsXmlConfigurationProcessor=UnusedFormalParameter
32+
org.apache.maven.cli.props.MavenProperties=CollapsibleIfStatements
33+
org.apache.maven.cli.transfer.ConsoleMavenTransferListener=UnusedFormalParameter
34+
org.apache.maven.cling.executor.embedded.Context=UnusedPrivateField
35+
org.apache.maven.cling.invoker.BaseParser=TooManyStaticImports
36+
org.apache.maven.cling.invoker.LookupInvoker=SimplifiedTernary
37+
org.apache.maven.cling.invoker.mvnsh.builtin.BuiltinShellCommandRegistry=UnusedFormalParameter
38+
org.apache.maven.cling.logging.impl.UnsupportedSlf4jBindingConfiguration=UnusedFormalParameter
39+
org.apache.maven.cling.props.MavenProperties=CollapsibleIfStatements
40+
org.apache.maven.cling.transfer.ConsoleMavenTransferListener=UnusedFormalParameter
41+
org.apache.maven.cling.utils.CLIReportingUtils=UnusedPrivateField
42+
org.apache.maven.configuration.BasedirBeanConfigurationPathTranslator=EmptyControlStatement
43+
org.apache.maven.di.impl.Types=JumbledIncrementer
44+
org.apache.maven.execution.MavenSession=UnusedFormalParameter
45+
org.apache.maven.impl.DefaultPluginXmlFactory=UnusedLocalVariable
46+
org.apache.maven.impl.DefaultSettingsBuilder=UnusedFormalParameter
47+
org.apache.maven.impl.DefaultToolchainsBuilder=UnusedFormalParameter
48+
org.apache.maven.impl.PathSelector=CollapsibleIfStatements
49+
org.apache.maven.impl.model.DefaultModelInterpolator=EmptyControlStatement
50+
org.apache.maven.impl.model.MavenModelMerger=UselessOverridingMethod,CollapsibleIfStatements
51+
org.apache.maven.impl.model.ModelBuilderSessionState=CollapsibleIfStatements
52+
org.apache.maven.impl.resolver.LocalSnapshotMetadataGenerator=UnusedFormalParameter
53+
org.apache.maven.impl.resolver.scopes.Maven3ScopeManagerConfiguration=TooManyStaticImports
54+
org.apache.maven.impl.resolver.scopes.Maven4ScopeManagerConfiguration=TooManyStaticImports
55+
org.apache.maven.internal.aether.DefaultRepositorySystemSessionFactory=EmptyControlStatement
56+
org.apache.maven.internal.impl.DefaultLifecycleRegistry=TooManyStaticImports
57+
org.apache.maven.internal.impl.DefaultTypeRegistry=CollapsibleIfStatements
58+
org.apache.maven.internal.transformation.impl.DefaultConsumerPomArtifactTransformer=UnusedPrivateMethod
59+
org.apache.maven.internal.transformation.impl.DefaultConsumerPomBuilder=UnusedFormalParameter
60+
org.apache.maven.internal.xml.DefaultXmlService=UnusedPrivateMethod
61+
org.apache.maven.lifecycle.DefaultLifecycles=UnusedFormalParameter
62+
org.apache.maven.lifecycle.LifecycleExecutionException=UnusedFormalParameter
63+
org.apache.maven.lifecycle.internal.MojoExecutor=UnusedLocalVariable
64+
org.apache.maven.lifecycle.internal.builder.BuilderCommon=EmptyControlStatement
65+
org.apache.maven.lifecycle.internal.concurrent.BuildContext=UnusedLocalVariable,CollapsibleIfStatements,EmptyControlStatement
66+
org.apache.maven.lifecycle.internal.concurrent.BuildPlanExecutor=TooManyStaticImports
67+
org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx=UselessOverridingMethod
68+
org.apache.maven.model.io.xpp3.MavenXpp3WriterEx=UselessOverridingMethod
69+
org.apache.maven.model.merge.MavenModelMerger=CollapsibleIfStatements
70+
org.apache.maven.model.merge.ModelMerger=CollapsibleIfStatements
71+
org.apache.maven.model.validation.DefaultModelValidator=UnusedFormalParameter
72+
org.apache.maven.plugin.CycleDetectedInPluginGraphException=UnusedFormalParameter
73+
org.apache.maven.plugin.PluginConfigurationException=UnusedPrivateField
74+
org.apache.maven.plugin.PluginParameterExpressionEvaluator=EmptyControlStatement
75+
org.apache.maven.plugin.PluginParameterExpressionEvaluatorV4=CollapsibleIfStatements,EmptyControlStatement
76+
org.apache.maven.project.DefaultProjectBuilder=UnusedFormalParameter
77+
org.apache.maven.project.MavenProject=UnusedFormalParameter,CollapsibleIfStatements
78+
org.apache.maven.project.interpolation.RegexBasedModelInterpolator=UnusedFormalParameter
79+
org.apache.maven.project.path.DefaultPathTranslator=CollapsibleIfStatements
80+
org.apache.maven.repository.DefaultMirrorSelector=AvoidUsingHardCodedIP
81+
org.apache.maven.repository.internal.LocalSnapshotMetadataGenerator=UnusedFormalParameter
82+
org.apache.maven.repository.internal.scopes.Maven3ScopeManagerConfiguration=TooManyStaticImports
83+
org.apache.maven.repository.internal.scopes.Maven4ScopeManagerConfiguration=TooManyStaticImports
84+
org.apache.maven.repository.legacy.DefaultUpdateCheckManager=UnusedLocalVariable
85+
org.apache.maven.repository.legacy.DefaultWagonManager=UnusedFormalParameter
86+
org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector=CollapsibleIfStatements
87+
org.apache.maven.repository.metadata.ArtifactMetadata=UnusedFormalParameter
88+
org.apache.maven.repository.metadata.DefaultGraphConflictResolver=UnusedFormalParameter
89+
org.apache.maven.repository.metadata.MetadataGraph=UnusedFormalParameter
90+
org.apache.maven.repository.metadata.MetadataGraphEdge=OverrideBothEqualsAndHashcode
91+
org.apache.maven.settings.building.DefaultSettingsBuilder=UnusedFormalParameter
92+
org.apache.maven.slf4j.DefaultLogLevelRecorder=CollapsibleIfStatements,AvoidBranchingStatementAsLastInLoop
93+
org.apache.maven.toolchain.building.DefaultToolchainsBuilder=UnusedFormalParameter
94+
org.apache.maven.toolchain.java.DefaultJavaToolChain=UselessOverridingMethod

‎pom.xml

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -799,17 +799,37 @@ under the License.</licenseText>
799799
<plugin>
800800
<groupId>org.apache.maven.plugins</groupId>
801801
<artifactId>maven-pmd-plugin</artifactId>
802+
<configuration>
803+
<analysisCache>true</analysisCache>
804+
<excludeFromFailureFile>.pmd/exclude.properties</excludeFromFailureFile>
805+
<minimumPriority>3</minimumPriority>
806+
<printFailingErrors>true</printFailingErrors>
807+
</configuration>
802808
<dependencies>
803809
<dependency>
804810
<groupId>net.sourceforge.pmd</groupId>
805811
<artifactId>pmd-core</artifactId>
806812
<version>7.12.0</version>
807813
</dependency>
808814
</dependencies>
815+
<executions>
816+
<execution>
817+
<id>maven-pmd-plugin</id>
818+
<goals>
819+
<goal>check</goal>
820+
</goals>
821+
<phase>verify</phase>
822+
</execution>
823+
</executions>
809824
</plugin>
810825
</plugins>
811826
</pluginManagement>
812827
<plugins>
828+
<!-- why profile not working? -->
829+
<plugin>
830+
<groupId>org.apache.maven.plugins</groupId>
831+
<artifactId>maven-pmd-plugin</artifactId>
832+
</plugin>
813833
<plugin>
814834
<groupId>io.github.olamy.maven.plugins</groupId>
815835
<artifactId>jacoco-aggregator-maven-plugin</artifactId>
@@ -1170,5 +1190,19 @@ under the License.</licenseText>
11701190
</plugins>
11711191
</build>
11721192
</profile>
1193+
<profile>
1194+
<id>pmd</id>
1195+
<activation>
1196+
<activeByDefault>true</activeByDefault>
1197+
</activation>
1198+
<build>
1199+
<plugins>
1200+
<plugin>
1201+
<groupId>org.apache.maven.plugins</groupId>
1202+
<artifactId>maven-pmd-plugin</artifactId>
1203+
</plugin>
1204+
</plugins>
1205+
</build>
1206+
</profile>
11731207
</profiles>
11741208
</project>

0 commit comments

Comments
 (0)