From b4aeddaa67d2b6a87a7cba5eaf7df79db7b90517 Mon Sep 17 00:00:00 2001 From: Konrad Windszus Date: Tue, 27 Aug 2024 18:28:26 +0200 Subject: [PATCH] [MRELEASE-1154] Improve exception message for unresolvable version expressions --- .../shared/release/phase/AbstractRewritePomsPhase.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java b/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java index 76747c56..9995357d 100644 --- a/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java +++ b/maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/AbstractRewritePomsPhase.java @@ -616,16 +616,17 @@ private void rewriteArtifactVersions( + rawVersion); } else { // the expression used to define the version of this artifact may be inherited - // TODO needs a better error message, what pom? what dependency? throw new ReleaseFailureException( - "Could not find property resolving version expression: " + rawVersion); + "Could not find property resolving version expression: " + rawVersion + + " for artifact " + key + " in the project " + projectId + + "."); } } } else { // the expression used to define the version of this artifact may be inherited - // TODO needs a better error message, what pom? what dependency? throw new ReleaseFailureException( - "Could not find properties resolving version expression : " + rawVersion); + "Could not find properties resolving version expression : " + rawVersion + + " for artifact " + key + " in the project " + projectId + "."); } } else { // different/previous version not related to current release