[MDEPLOY-318] version 3.1.2 is uploading jar files to wrong endpoints

[jira-importer]

Michaël opened MDEPLOY-318 and commented

hi, i'm using spring-boot, and upon updating to 3.2.6 i noticed that my parent pom was uploaded corrupted.

[FATAL] Non-parseable POM ~/.m2/repository/nl/intractief/intr-parent/7.1.5/intr-parent-7.1.5.pom: only whitespace content allowed before start tag and not P (position: START_DOCUMENT seen P... @1:2)  @ ~/.m2/repository/nl/intractief/intr-parent/7.1.5/intr-parent-7.1.5.pom, line 1, column 2

 

• the same parent pom was correctly published using spring-boot 3.2.5
• the parent pom is correct before publishing in the pipeline (manually checked the target folder).
• after publishing i see binary stuff as pom (guess: zipped binary content)
• setting the maven-deploy-plugin.version in the project to 3.1.1 solves the issue.

in the spring-boot project i created an issue about this (see external issue link) and found another similar issue with a functional workaround.

we think there is an issue with the deployment endpoints in version 3.1.2 it seems the jars end up at the pom endpoints

 

 

---

Affects: 3.1.2

Attachments:

• pom.xml (1.19 kB)
• test-maven-deploy-0.0.1.zip (1.77 kB)
• test-maven-deploy-0.0.2.zip (1.77 kB)
• test-maven-parent-0.0.1.pom (1.64 kB)
• test-maven-parent-0.0.2.pom (1.18 kB)

Issue Links:

• MNG-8138 Maven internal state should not allow to become "broken"

[jira-importer]

Tamas Cservenak commented

Can you provide some minimal reproducer?

[jira-importer]

Tamas Cservenak commented

Seems strange that for you m-deploy-p 3.1.1 works while 3.1.2 does not, as literally the release notes is this: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317228&version=12354128

[jira-importer]

Michaël commented

i know, it's patch updates but the deploy really works when downgrading the deploy plugin.

i deploy from my gitlab-ci pipeline using

mvn jar:jar deploy:deploy -pl $MAVEN_MODULES -DaltDeploymentRepository=gitlab-maven::$MAVEN_REPOSITORY

but it only displays incorrect artifacts in the repository, so minimal reproduction requires a maven repository.

[jira-importer]

Michaël commented

spring-projects/spring-boot#40919 also contains some http debug log of the requests

[jira-importer]

Tamas Cservenak commented

Sure, just create a reproducer with some (even your URL to some repo) and I will replace it with some I have write access to.

[jira-importer]

Michaël commented

working on it in https://gitlab.com/tub/test-maven-deploy/ that includes the minimal pipeline i use

[jira-importer]

Michaël commented

ok

• https://gitlab.com/tub/test-maven-deploy/-/releases/0.0.1 this is the faulty deployed version
• https://gitlab.com/tub/test-maven-deploy/-/releases/0.0.2 this is the correct one

do you want me to add the source? (the above repo is public)

[jira-importer]

Michaël commented

[^pom.xml]

this is the pom; so the url should differ and you need credentials to publish, i change the used version using the maven-deploy-plugin.version property

[jira-importer]

Michaël commented

faulty version

[^test-maven-deploy-0.0.1.zip][^test-maven-parent-0.0.1.pom]

correct version

[^test-maven-deploy-0.0.2.zip][^test-maven-parent-0.0.2.pom]

[jira-importer]

Michaël commented

i think it's something here, i think determinating Artifact's deserves its own function and test

https://github.com/apache/maven-deploy-plugin/pull/47/files#diff-ffcc9777ab63d54259e77f8e53ab3fc9c1b4ae1de9554187ab2a097b41b9bd76

[jira-importer]

Tamas Cservenak commented

Unsure how to run this thing? Also, the pom is packaging "pom" so from where comes the ZIP? When I invoke this (for example {}mvn package{}) nothing happens, as expected in a way, as packaging is "pom"...

[jira-importer]

Tamas Cservenak commented

So, when I do deploy this happens: https://gist.github.com/cstamas/6466d942dbd56aa96e341432315b846d

Again, unsure from where the ZIP should come in this reproducer

[jira-importer]

Tamas Cservenak commented

With 3.1.2 of m-deploy-p same thing: https://gist.github.com/cstamas/a6fa1997c4922981dbced143127dce78

[jira-importer]

Tamas Cservenak commented

As I see, your problem is not Maven or Deploy plugin 3.1.2 but your CI script: https://gitlab.com/tub/test-maven-deploy/-/blob/main/.gitlab-ci.yml

That script is totally off: you explicitly invoke jar:jar and deploy:deploy 

Please look at the build lifecycles instead: https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html

[jira-importer]

Michaël commented

k, tnx, will look into that, i think we invoke the specific mojo's to prevent re-building the whole project when using the lifecycle (because of the split-up into script and after_script in the .gitlab-ci