Skip to content

Commit ae0efac

Browse files
authored
Enable GH issues (#522)
1 parent 1d15308 commit ae0efac

File tree

9 files changed

+136
-43
lines changed

9 files changed

+136
-43
lines changed

.asf.yaml

+3
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ github:
3030
rebase: true
3131
autolink_jira:
3232
- MDEP
33+
del_branch_on_merge: true
34+
features:
35+
issues: true
3336
notifications:
3437
3538

.github/ISSUE_TEMPLATE/BUG.yml

+48
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
#
2+
# Licensed to the Apache Software Foundation (ASF) under one or more
3+
# contributor license agreements. See the NOTICE file distributed with
4+
# this work for additional information regarding copyright ownership.
5+
# The ASF licenses this file to You under the Apache License, Version 2.0
6+
# (the "License"); you may not use this file except in compliance with
7+
# the License. You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing, software
12+
# distributed under the License is distributed on an "AS IS" BASIS,
13+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
# See the License for the specific language governing permissions and
15+
# limitations under the License.
16+
#
17+
18+
# https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema
19+
20+
name: Bug Report
21+
description: File a bug report
22+
labels: ["bug"]
23+
24+
body:
25+
- type: markdown
26+
attributes:
27+
value: |
28+
Thanks for taking the time to fill out this bug report.
29+
30+
Simple fixes in single PRs do not require issues.
31+
32+
**Do you use the latest project version?**
33+
34+
- type: input
35+
id: version
36+
attributes:
37+
label: Affected version
38+
validations:
39+
required: true
40+
41+
- type: textarea
42+
id: message
43+
attributes:
44+
label: Bug description
45+
validations:
46+
required: true
47+
48+

.github/ISSUE_TEMPLATE/FEATURE.yml

+35
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
#
2+
# Licensed to the Apache Software Foundation (ASF) under one or more
3+
# contributor license agreements. See the NOTICE file distributed with
4+
# this work for additional information regarding copyright ownership.
5+
# The ASF licenses this file to You under the Apache License, Version 2.0
6+
# (the "License"); you may not use this file except in compliance with
7+
# the License. You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing, software
12+
# distributed under the License is distributed on an "AS IS" BASIS,
13+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
# See the License for the specific language governing permissions and
15+
# limitations under the License.
16+
#
17+
18+
# https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema
19+
20+
name: Feature request
21+
description: File a proposal for new feature, improvement
22+
labels: ["enhancement"]
23+
24+
body:
25+
- type: markdown
26+
attributes:
27+
value: |
28+
Thanks for taking the time to fill out this new feature, improvement proposal.
29+
30+
- type: textarea
31+
id: message
32+
attributes:
33+
label: New feature, improvement proposal
34+
validations:
35+
required: true

.github/ISSUE_TEMPLATE/config.yml

+30
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
#
2+
# Licensed to the Apache Software Foundation (ASF) under one or more
3+
# contributor license agreements. See the NOTICE file distributed with
4+
# this work for additional information regarding copyright ownership.
5+
# The ASF licenses this file to You under the Apache License, Version 2.0
6+
# (the "License"); you may not use this file except in compliance with
7+
# the License. You may obtain a copy of the License at
8+
#
9+
# http://www.apache.org/licenses/LICENSE-2.0
10+
#
11+
# Unless required by applicable law or agreed to in writing, software
12+
# distributed under the License is distributed on an "AS IS" BASIS,
13+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
# See the License for the specific language governing permissions and
15+
# limitations under the License.
16+
#
17+
18+
# https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser
19+
20+
blank_issues_enabled: false
21+
22+
contact_links:
23+
24+
- name: Project Mailing Lists
25+
url: https://maven.apache.org/mailing-lists.html
26+
about: Please ask a question or discuss here
27+
28+
- name: Old JIRA Issues
29+
url: https://issues.apache.org/jira/projects/MDEP
30+
about: Please search old JIRA issues

.github/pull_request_template.md

+13-19
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,23 @@
1-
Following this checklist to help us incorporate your
1+
Following this checklist to help us incorporate your
22
contribution quickly and easily:
33

4-
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MDEP) filed
5-
for the change (usually before you start working on it). Trivial changes like typos do not
6-
require a JIRA issue. Your pull request should address just this issue, without
7-
pulling in other changes.
8-
- [ ] Each commit in the pull request should have a meaningful subject line and body.
9-
- [ ] Format the pull request title like `[MDEP-XXX] - Fixes bug in ApproximateQuantiles`,
10-
where you replace `MDEP-XXX` with the appropriate JIRA issue. Best practice
11-
is to use the JIRA issue title in the pull request title and in the first line of the
12-
commit message.
13-
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
14-
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
15-
be performed on your pull request automatically.
16-
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
4+
- [ ] Your pull request should address just one issue, without pulling in other changes.
5+
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
6+
- [ ] Each commit in the pull request should have a meaningful subject line and body.
7+
Note that commits might be squashed by a maintainer on merge.
8+
- [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
9+
This may not always be possible but is a best-practice.
10+
- [ ] Run `mvn verify` to make sure basic checks pass.
11+
A more thorough check will be performed on your pull request automatically.
12+
- [ ] You have run the integration tests successfully (`mvn -Prun-its verify`).
1713

1814
If your pull request is about ~20 lines of code you don't need to sign an
1915
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
2016
please ask on the developers list.
2117

22-
To make clear that you license your contribution under
18+
To make clear that you license your contribution under
2319
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
2420
you have to acknowledge this by using the following check-box.
2521

26-
- [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
27-
28-
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
29-
22+
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
23+
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).

.github/release-drafter.yml

-1
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,3 @@
1818
# under the License.
1919

2020
_extends: maven-gh-actions-shared
21-
tag-template: maven-dependency-plugin-$RESOLVED_VERSION

.github/workflows/release-drafter.yml

+1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ on:
2222
push:
2323
branches:
2424
- master
25+
workflow_dispatch:
2526

2627
jobs:
2728
update_release_draft:

README.md

+4-21
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,13 @@
1717
Contributing to [Apache Maven Dependency Plugin](https://maven.apache.org/plugins/maven-dependency-plugin/)
1818
======================
1919

20-
[![ASF Jira](https://img.shields.io/endpoint?url=https%3A%2F%2Fmaven.apache.org%2Fbadges%2Fasf_jira-MDEP.json)][jira]
2120
[![Apache License, Version 2.0, January 2004](https://img.shields.io/github/license/apache/maven.svg?label=License)][license]
2221
[![Maven Central](https://img.shields.io/maven-central/v/org.apache.maven.plugins/maven-dependency-plugin.svg?label=Maven%20Central)](https://search.maven.org/artifact/org.apache.maven.plugins/maven-dependency-plugin)
2322
[![Reproducible Builds](https://img.shields.io/endpoint?url=https://raw.githubusercontent.com/jvm-repo-rebuild/reproducible-central/master/content/org/apache/maven/plugins/maven-dependency-plugin//badge.json)](https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/maven/plugins/maven-dependency-plugin/README.md)
2423
[![Jenkins Status](https://img.shields.io/jenkins/s/https/ci-maven.apache.org/job/Maven/job/maven-box/job/maven-dependency-plugin/job/master.svg?)][build]
2524
[![Jenkins tests](https://img.shields.io/jenkins/t/https/ci-maven.apache.org/job/Maven/job/maven-box/job/maven-dependency-plugin/job/master.svg?)][test-results]
2625

27-
28-
You have found a bug or you have an idea for a cool new feature? Contributing
26+
You have found a bug, or you have an idea for a cool new feature? Contributing
2927
code is a great way to give something back to the open source community. Before
3028
you dig right into the code, there are a few guidelines that we need
3129
contributors to follow so that we can have a chance of keeping on top of
@@ -34,7 +32,6 @@ things.
3432
Getting Started
3533
---------------
3634

37-
+ Make sure you have a [JIRA account](https://issues.apache.org/jira/).
3835
+ Make sure you have a [GitHub account](https://github.com/signup/free).
3936
+ If you're planning to implement a new feature, it makes sense to discuss your changes
4037
on the [dev list][ml-list] first.
@@ -60,37 +57,23 @@ There are some guidelines which will make applying PRs easier for us:
6057
+ Create minimal diffs - disable on save actions like reformat source code or organize imports.
6158
If you feel the source code should be reformatted, create a separate PR for this change.
6259
+ Check for unnecessary whitespace with `git diff --check` before committing.
63-
+ Make sure your commit messages are in the proper format. Your commit message should contain the key of the JIRA issue.
64-
```
65-
[MDEP-XXX] - Subject of the JIRA Ticket
66-
Optional supplemental description.
67-
```
6860
+ Make sure you have added the necessary tests (JUnit/IT) for your changes.
6961
+ Run all the tests with `mvn -Prun-its verify` to assure nothing else was accidentally broken.
7062
+ Submit a pull request to the repository in the Apache organization.
71-
+ Update your JIRA ticket and include a link to the pull request in the ticket.
7263

7364
If you plan to contribute on a regular basis, please consider filing a [contributor license agreement][cla].
7465

75-
Making Trivial Changes
76-
----------------------
77-
78-
For changes of a trivial nature to comments and documentation, it is not always
79-
necessary to create a new ticket in JIRA. In this case, it is appropriate to
80-
start the first line of a commit with '(doc)' instead of a ticket number.
81-
8266
Additional Resources
8367
--------------------
8468

8569
+ [Contributing patches](https://maven.apache.org/guides/development/guide-maven-development.html#Creating_and_submitting_a_patch)
86-
+ [Apache Maven Dependency JIRA project page][jira]
8770
+ [Contributor License Agreement][cla]
8871
+ [General GitHub documentation](https://help.github.com/)
8972
+ [GitHub pull request documentation](https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork)
90-
+ [Apache Maven Twitter Account](https://twitter.com/ASFMavenProject)
91-
+ #Maven IRC channel on freenode.org
73+
+ [Apache Maven X Account](https://x.com/ASFMavenProject)
74+
+ [Apache Maven Bluesky Account](https://bsky.app/profile/maven.apache.org)
75+
+ [Apache Maven Mastodon Account](https://mastodon.social/deck/@[email protected])
9276

93-
[jira]: https://issues.apache.org/jira/projects/MDEP/
9477
[license]: https://www.apache.org/licenses/LICENSE-2.0
9578
[ml-list]: https://maven.apache.org/mailing-lists.html
9679
[code-style]: https://maven.apache.org/developers/conventions/code.html

pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ under the License.
7575
<url>https://github.com/apache/maven-dependency-plugin/tree/${project.scm.tag}</url>
7676
</scm>
7777
<issueManagement>
78-
<system>JIRA</system>
79-
<url>https://issues.apache.org/jira/browse/MDEP</url>
78+
<system>GitHub Issues</system>
79+
<url>https://github.com/apache/maven-dependency-plugin/issues</url>
8080
</issueManagement>
8181
<ciManagement>
8282
<system>Jenkins</system>

0 commit comments

Comments
 (0)