Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Executor执行器中beforeImage和afterImage方法返回值只考虑了sql语句涉及一张表的情况，无法承接涉及多张表的SQL语句，如MultiUpdateExecutor #4975

Open
renliangyu857 opened this issue Oct 3, 2022 · 0 comments · May be fixed by #5220
Open

Executor执行器中beforeImage和afterImage方法返回值只考虑了sql语句涉及一张表的情况，无法承接涉及多张表的SQL语句，如MultiUpdateExecutor #4975

renliangyu857 opened this issue Oct 3, 2022 · 0 comments · May be fixed by #5220
Assignees
@renliangyu857
Labels
task: help-wanted Extra attention is needed

Comments

@renliangyu857
Copy link
Contributor

Why you need it?

Is your feature request related to a problem? Please describe in details
1664809498717
这里的beforeImage只考虑了一张表，但像MultiExecutor这种可能涉及多张表，目前是在内部通过维护map结构实现的，返回值是null，语义上不太明确。可考虑beforeImage的抽象方法返回值定义为泛型，由各个子类根据实际情况承接不同的返回值
1664809577085

How it could be?

A clear and concise description of what you want to happen. You can explain more about input of the feature, and output of it.

Other related information

Add any other context or screenshots about the feature request here.
@slievrly slievrly added the task: help-wanted Extra attention is needed label Oct 12, 2022
@renliangyu857 renliangyu857 linked a pull request Dec 30, 2022 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@renliangyu857 renliangyu857

Labels
task: help-wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

optimize: modify the return type of image method to be generic renliangyu857/seata
2 participants
@slievrly @renliangyu857