Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] build manager image in build-images.sh #278

Open
Radeity opened this issue Oct 31, 2023 · 4 comments
Open

[Feature] build manager image in build-images.sh #278

Radeity opened this issue Oct 31, 2023 · 4 comments
Labels
feature New feature

Comments

@Radeity
Copy link
Member

Radeity commented Oct 31, 2023

Feature Description (功能描述)

Now, we have manager container introduced by #259. Thus, we have to modify image building script.

BTW, may I ask, currently, how to trigger new image building and uploading in HugeGraphComputer? It seems like publish_images.yml in .workflow is deprecated?

@Radeity Radeity added the feature New feature label Oct 31, 2023
@Radeity Radeity changed the title [Feature] push manager image in build-images.sh [Feature] build manager image in build-images.sh Oct 31, 2023
@Radeity
Copy link
Member Author

Radeity commented Oct 31, 2023

cc @coderzc

@imbajin
Copy link
Member

imbajin commented Oct 31, 2023

Feature Description (功能描述)

Now, we have manager container introduced by #259. Thus, we have to modify image building script.

BTW, may I ask, currently, how to trigger new image building and uploading in HugeGraphComputer? It seems like publish_images.yml in .workflow is deprecated?

due to lack some "GITHUB_TOKEN" permission here, so transfer to
https://github.com/hugegraph/actions/blob/master/.github/workflows/publish_computer_image.yml

so as other similar CIs

@Radeity
Copy link
Member Author

Radeity commented Oct 31, 2023

Hi @imbajin , get it, thanks.

However, may I ask why we comment the cron schedule in publish_computer_image.yml? If we comment these, we should let user know how to build the latest images by themselves, maybe have to maintain the latest script(with new image manager) in this repo, either, and declare in our doc.
https://github.com/hugegraph/actions/blob/4eb9db3d644408df8f47558ecf151b510a1ffd24/.github/workflows/publish_computer_image.yml#L3-L5

@imbajin
Copy link
Member

imbajin commented Nov 1, 2023

Hi @imbajin , get it, thanks.

However, may I ask why we comment the cron schedule in publish_computer_image.yml? If we comment these, we should let user know how to build the latest images by themselves, maybe have to maintain the latest script(with new image manager) in this repo, either, and declare in our doc. hugegraph/actions@4eb9db3/.github/workflows/publish_computer_image.yml#L3-L5

Good catch & thanks for the reminder (Context: computer has not been updated for a period of time before, and it is unreasonable to keep updating the image on a regular crontab. We should use a hook mechanism that updates when there is a new commit)

@Radeity could u follow the PR (hugegraph/actions#2) to update computer image with hook m* when free? (also divide it into 2 ci action for release/stable version)

If not free these days, could assign to @aroundabout & comment here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

2 participants