Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic replica management using replicaCount to enable or disable DEV-LAKE. #266

Open
angelsanchezdck opened this issue Mar 27, 2024 · 5 comments

Comments

@angelsanchezdck
Copy link

Knowing that the dev-lake deployments cannot have more than one replica, we would like to have the ability to manage the replicas of StatefulSet and deployments to set to 0, and then completely disable devlake-helm-chart.

Current configuration:

spec:
  replicas: 1

Changes for StatefulSet and deployments :

spec:
  replicas: {{ if gt .Values.replicaCount 1 }}1{{ else }}{{ .Values.replicaCount }}{{ end }}

If you find it convenient:

Changes for StatefulSet and Deployment (devlake-ui)

spec:
  replicas: {{ .Values.replicaCount }}

Change for Deployment (dev-lake)

spec:
  replicas: {{ if gt .Values.replicaCount 1 }}1{{ else }}{{ .Values.replicaCount }}{{ end }}
@ZhangNing10
Copy link
Contributor

hi @angelsanchezdck , that's a good point, could you open a pr for that?

@ZhangNing10
Copy link
Contributor

config-ui can have multiple replicas @angelsanchezdck

@angelsanchezdck
Copy link
Author

Done ✔️
pr: #269

@angelsanchezdck
Copy link
Author

HI, any update?

@ZhangNing10
Copy link
Contributor

hi @angelsanchezdck , thanks a lot for the pr! appreciated! i see there is conflict, could you fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants