Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add macro to help write error message #746

Closed
jiacai2050 opened this issue Mar 16, 2023 · 6 comments
Closed

add macro to help write error message #746

jiacai2050 opened this issue Mar 16, 2023 · 6 comments
Labels
good first issue Good for newcomers

Comments

@jiacai2050
Copy link
Contributor

jiacai2050 commented Mar 16, 2023

        #[snafu(display(
            "Failed to build influxql plan with no cause, msg:{}.\nBacktrace:\n{}",
            msg,
            backtrace
        ))]
        BuildPlanNoCause { msg: String, backtrace: Backtrace },

Add a display_backtrace macro to simplify error message, something like:

display_backtrace!("Failed to build influxql plan with no cause, msg:{}.", msg)

It will rewrite to line above.

Originally posted by @jiacai2050 in #745 (comment)

@jiacai2050 jiacai2050 added the good first issue Good for newcomers label Mar 16, 2023
@yuhaoran1214
Copy link
Contributor

Hi, is this issue available?if so, can I try on this?

@jiacai2050
Copy link
Contributor Author

Thanks, assigned.

@jiacai2050
Copy link
Contributor Author

@Apricity001 Any progress? It has been quiet for a while.

@yuhaoran1214
Copy link
Contributor

Sorry, I'm a little busy recently,I want to give up it.

@jiacai2050
Copy link
Contributor Author

Thanks for response, unassigned.

@jiacai2050
Copy link
Contributor Author

Not need any more, see #1513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants