Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRILL-8506: Ignore JSON Elements with Empty Keys #2935

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

cgivre
Copy link
Contributor

@cgivre cgivre commented Aug 13, 2024

DRILL-8506: Ignore JSON Elements with Empty Keys

Description

If Drill encounters a JSON field with an empty key, currently Drill throws an exception. This behavior prevents Drill from reading the rest of the data. This PR modifies Drill's behavior by simply ignoring JSON data with empty keys. Drill will generate a log warning message when this happens.

Documentation

No significant user facing changes.

Testing

Ran existing unit tests.

@cgivre cgivre added minor-update backport-to-stable This bug fix is applicable to the latest stable release and should be considered for inclusion there labels Aug 13, 2024
@cgivre cgivre self-assigned this Aug 13, 2024
Copy link
Member

@rymarm rymarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@cgivre
Copy link
Contributor Author

cgivre commented Aug 25, 2024

Unless anyone has any objections, I'm going to merge this. It seems that whatever was going wrong with the CI has magically fixed itself. Although some unrelated Hive tests are failing due to connections being dropped, but only for Hadoop 2....

@cgivre cgivre merged commit 11aaa3f into apache:master Aug 26, 2024
6 of 8 checks passed
@cgivre cgivre deleted the json_empty_key branch August 26, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-stable This bug fix is applicable to the latest stable release and should be considered for inclusion there minor-update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants