DRILL-8503: Add Configuration Option to Skip Host Validation for Splunk #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgivre
added
enhancement
jnturton
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-8503: Add Configuration Option to Skip Host Validation for Splunk
Description
in corporate installations, sometimes the organization will use self-signed certificates which can cause problems. This PR adds an option to bypass host validation for SSL connections in Splunk. The "correct" way to fix this would be to provide better SSL information, to include the certificate in the Splunk connection, however, Splunk's SDK does not allow for this and there are several open issues and PRs relating to this.
This PR also bumps the Splunk SDK version to the latest version which is 1.9.5.
Documentation
An additional configuration option:
validateHostnameshas been added to the Splunk configuration. I updated the README.md file with this information and will be updating the documentation once this has been merged.Testing
Ran existing unit tests and tested manually.