DRILL-8420: Remove shaded Guava and upgrade stock Guava 30.1.1-jre → 32.1.2-jre #2827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnturton
force-pushed
the
8420-stock-guava
branch
from
63626aa
to
29f63ed
Compare
jnturton
changed the title
jnturton
force-pushed
the
8420-stock-guava
branch
from
29f63ed
to
048c219
Compare
cgivre
pushed a commit
to cgivre/drill
that referenced
this pull request
Nov 2, 2023
…32.1.2-jre (apache#2827) * Remove Drill's shaded Guava. * Upgrade Guava 30.1.1-jre → 32.1.2-jre. * Suppress checkstyle warnings of "Unable to locate Source XRef".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-8420: Remove shaded Guava and upgrade stock Guava 30.1.1-jre → 32.1.2-jre
Description
The Drill JDBC driver shrinks by ~6Mb as a result.
Note to reviewers: the 1.2k Guava import statement updates included in this PR are all isolated in the
Update org.apache.drill.shaded.guava.* import statements.commit which may be ignored (or checked with a script) when reviewing.Documentation
N/A
Testing
All unit tests pass. Manual testing of Drill web UI and JDBC driver. Manual review of
mvn dependency:tree