-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRILL-8454: Disable unsupported MapR profile and plugin #2825
Conversation
ea68c28
to
29f17fb
Compare
1dbf760
to
8fc3b8b
Compare
This one's ready for review. |
8fc3b8b
to
c132445
Compare
c132445
to
5a28b08
Compare
A note to the reviewers. Git's default diff algorithm makes it very hard to see that the changes this PR makes to pom.xml are simply whole sections moving into comment blocks. GitHub does not allow users to select the diff algorithm at this time so, to ease review, I have therefore uploaded the diff of pom.xml generated using |
@jnturton Hi! I'll take a look at this pull request this week later or even next week. I've just got back from a vacation and got on a "burning boat" of work) But I have a question now, Why did you decide to comment the mapr specific changes, but not completely remove them? And in addition, I suppose that we also need to remove mentions of maprdb support from the documentation or leave a link to HPE documentation. |
@rymarm welcome back! I wasn't sure whether to delete or comment out the mapr modules. I decided to try moving them to new, commented out sections of "Objects of type foo that are no longer supported" that seemed to keep an informative history in the source files without a lot of extra cruft. But that history is always available in Git so I'm also happy to delete instead... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
In general I don't like leaving commented out code blocks, but in the event that someone wants to use a current version of Drill with MapR, I do think it is fine to leave them for a while.
@jnturton Can we merge this? |
5a28b08
to
d1b16f3
Compare
d1b16f3
to
a65db5e
Compare
DRILL-8454: Disable unsupported MapR profile and plugin
Description
The MapR build profile and format plugin, which fell out of support in the open source Drill codebase years ago, are disabled. Drill users needing support for these components should contact HPE.
Documentation
See the HPE Ezmeral docs.
Testing
Build and unit tests of remaining modules pass.