DRILL-8449: fix typo in width property in FreeMarker templates #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rymarm |
jnturton
approved these changes
Aug 8, 2023
cgivre
pushed a commit
to cgivre/drill
that referenced
this pull request
Nov 2, 2023
jnturton
pushed a commit
that referenced
this pull request
Dec 31, 2023
jnturton
pushed a commit
to jnturton/drill
that referenced
this pull request
Dec 31, 2023
jnturton
pushed a commit
to jnturton/drill
that referenced
this pull request
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRILL-8449: Typo in FreeMarker templates
Description
CSS-based properties use a colon(
:) to assign values. Theresult.ftlandoptions.ftlhave the propertywidthwith an equal sign(=) instead of a colon(:).This typo makes a query result table has an incorrect display.
Steps to reproduce:
select full_name from cp.employee.jsonlimit 1;Documentation
None requerid
Testing
Visual test of UI