Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRILL-5955: Revisit Union Vectors #2543

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vdiravka
Copy link
Member

DRILL-5955: Revisit Union Vectors

Description

Draft PR for support Union type for JSON2

  • Enabled Union/Variant vectors for JSON2
  • fix validation for Union vectors
  • fix List vector in the Union vector
  • check all existing tests work fine

Documentation

TBA

Testing

existing tests will be enabled for JSON2

@cgivre
Copy link
Contributor

cgivre commented May 10, 2022

@vdiravka This is looking good. Quick question, can we add a configuration variable to the JSON Format to enable/disable this at the plugin instance level?

@cgivre cgivre added enhancement PRs that add a new functionality to Drill doc-impacting PRs that affect the documentation json JSON Format labels May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-impacting PRs that affect the documentation enhancement PRs that add a new functionality to Drill json JSON Format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants