[Fix](multi catalog)(planner) Fix external table statistic collection bug. #16486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
reviewed
Feb 7, 2023
| @@ -85,7 +86,7 @@ protected void getColumnStatsByMeta() throws Exception { | |||
| Map<String, String> parameters = table.getRemoteTable().getParameters(); | |||
| // Collect table level row count, null number and timestamp. | |||
| setParameterData(parameters, params); | |||
| params.put("id", String.valueOf(tbl.getId()) + "-" + String.valueOf(col.getName())); | |||
| params.put("id", String.valueOf(tbl.getId()) + "--1-" + col.getName()); | |||
There was a problem hiding this comment.
I think we should extract a method to do this, currently, it is very error prone
| @@ -294,6 +294,7 @@ public Partition getPartition(List<String> partitionValues) { | |||
|
|
|||
| @Override | |||
| public List<Column> initSchema() { | |||
| makeSureInitialized(); | |||
There was a problem hiding this comment.
Without this initialization, FE will throw NPE when excuting analyze table hms_catalog.db.table immediately after FE started.
morningman
pushed a commit
that referenced
this pull request
Feb 8, 2023
… bug (#16486) Add index id to column statistic id. Refresh statistic cache after analyze.
YangShaw
pushed a commit
to YangShaw/doris
that referenced
this pull request
Feb 17, 2023
… bug (apache#16486) Add index id to column statistic id. Refresh statistic cache after analyze.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
Add index id to column statistic id. Refresh statistic cache after analyze.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...