Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Outfile) optimize the error message of SELECT INTO OUTFILE #45859

Merged
merged 2 commits into from
Dec 25, 2024
Merged

[fix](Outfile) optimize the error message of SELECT INTO OUTFILE #45859

merged 2 commits into from
Dec 25, 2024
+1 −1

Conversation

BePPPower
Copy link
Contributor

optimize the error message of SELECT INTO OUTFILE

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BePPPower
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39760 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3e2b022f51929a2808145730d1f721739fb1d424, data reload: false

------ Round 1 ----------------------------------
q1	17591	7410	7241	7241
q2	2045	181	179	179
q3	10767	1077	1155	1077
q4	10586	723	715	715
q5	7593	2662	2608	2608
q6	242	155	154	154
q7	985	635	617	617
q8	9238	1871	1892	1871
q9	6670	6402	6456	6402
q10	7013	2338	2332	2332
q11	464	259	260	259
q12	410	218	222	218
q13	17794	2907	2968	2907
q14	247	208	213	208
q15	568	524	509	509
q16	663	604	587	587
q17	968	557	614	557
q18	7300	6818	6589	6589
q19	1393	1021	978	978
q20	476	188	189	188
q21	4277	3273	3255	3255
q22	374	323	309	309
Total cold run time: 107664 ms
Total hot run time: 39760 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7209	7175	7231	7175
q2	327	234	228	228
q3	2902	2828	2945	2828
q4	2043	1752	1784	1752
q5	5680	5648	5650	5648
q6	223	142	141	141
q7	2284	1790	1847	1790
q8	3351	3502	3532	3502
q9	9005	8970	8949	8949
q10	3624	3561	3577	3561
q11	605	516	519	516
q12	800	618	613	613
q13	12770	3109	3156	3109
q14	326	290	275	275
q15	550	514	503	503
q16	697	651	655	651
q17	1835	1645	1618	1618
q18	8422	7971	7605	7605
q19	3447	1454	1458	1454
q20	2057	1895	1858	1858
q21	5577	5426	5449	5426
q22	664	592	595	592
Total cold run time: 74398 ms
Total hot run time: 59794 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198217 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3e2b022f51929a2808145730d1f721739fb1d424, data reload: false

query1	1269	967	912	912
query2	6231	2367	2370	2367
query3	11066	4761	4928	4761
query4	33309	23546	23401	23401
query5	4311	486	469	469
query6	297	189	198	189
query7	3982	306	309	306
query8	325	274	242	242
query9	9668	2764	2776	2764
query10	504	254	270	254
query11	17921	15352	15455	15352
query12	169	106	108	106
query13	1616	437	419	419
query14	11063	7116	7419	7116
query15	282	183	188	183
query16	8038	470	507	470
query17	1682	623	613	613
query18	2171	314	332	314
query19	370	200	164	164
query20	132	114	116	114
query21	204	110	110	110
query22	4778	4590	4493	4493
query23	34231	33831	33914	33831
query24	10398	2577	2510	2510
query25	610	399	393	393
query26	1160	156	152	152
query27	2526	346	344	344
query28	7868	2510	2503	2503
query29	831	417	420	417
query30	235	146	144	144
query31	1055	860	850	850
query32	117	58	55	55
query33	766	311	310	310
query34	1100	532	523	523
query35	904	755	755	755
query36	1114	968	977	968
query37	154	79	76	76
query38	4284	4276	4159	4159
query39	1519	1473	1454	1454
query40	204	103	106	103
query41	50	42	48	42
query42	116	108	104	104
query43	543	522	500	500
query44	1244	837	843	837
query45	204	164	173	164
query46	1201	749	759	749
query47	2083	1948	1978	1948
query48	436	331	321	321
query49	899	385	408	385
query50	838	423	411	411
query51	7400	7246	7126	7126
query52	105	92	96	92
query53	265	195	189	189
query54	1140	423	435	423
query55	84	78	77	77
query56	270	245	257	245
query57	1310	1210	1178	1178
query58	238	213	219	213
query59	3471	3126	3143	3126
query60	281	243	259	243
query61	108	108	107	107
query62	928	745	797	745
query63	222	201	198	198
query64	3960	758	655	655
query65	3309	3292	3224	3224
query66	797	299	318	299
query67	16581	15667	15592	15592
query68	5297	575	578	575
query69	474	253	249	249
query70	1217	1132	1136	1132
query71	483	262	248	248
query72	7055	4046	4134	4046
query73	797	376	371	371
query74	10601	9116	8935	8935
query75	3725	2641	2663	2641
query76	3691	1065	1065	1065
query77	587	350	288	288
query78	10290	9473	9452	9452
query79	1098	614	613	613
query80	825	431	445	431
query81	511	228	233	228
query82	268	128	115	115
query83	180	149	148	148
query84	268	70	79	70
query85	1042	309	303	303
query86	356	301	310	301
query87	4517	4691	4605	4605
query88	3358	2248	2230	2230
query89	435	292	290	290
query90	2124	189	190	189
query91	142	117	107	107
query92	68	52	53	52
query93	1347	569	554	554
query94	795	287	299	287
query95	355	260	248	248
query96	612	286	286	286
query97	2866	2685	2691	2685
query98	222	201	201	201
query99	1697	1461	1413	1413
Total cold run time: 303850 ms
Total hot run time: 198217 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.45 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3e2b022f51929a2808145730d1f721739fb1d424, data reload: false

query1	0.04	0.03	0.05
query2	0.07	0.03	0.03
query3	0.24	0.07	0.06
query4	1.62	0.10	0.11
query5	0.43	0.41	0.41
query6	1.16	0.68	0.66
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.56	0.52	0.51
query10	0.57	0.56	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.10
query13	0.61	0.60	0.61
query14	2.73	2.72	2.73
query15	0.89	0.82	0.84
query16	0.38	0.37	0.39
query17	1.05	1.07	1.01
query18	0.23	0.21	0.21
query19	1.91	1.85	2.00
query20	0.01	0.01	0.01
query21	15.36	0.56	0.59
query22	2.88	2.12	1.98
query23	16.81	1.07	0.91
query24	3.03	1.50	1.72
query25	0.39	0.10	0.05
query26	0.55	0.15	0.14
query27	0.05	0.05	0.04
query28	9.73	1.12	1.08
query29	12.59	3.24	3.24
query30	0.25	0.07	0.07
query31	2.85	0.39	0.37
query32	3.22	0.47	0.46
query33	3.10	3.14	3.12
query34	16.94	4.44	4.52
query35	4.55	4.51	4.52
query36	0.66	0.49	0.50
query37	0.10	0.05	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.02
query40	0.17	0.12	0.13
query41	0.07	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.3 s
Total hot run time: 33.45 s

morningman
morningman approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit 8594a67 into apache:master Dec 25, 2024
26 of 27 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 25, 2024
@BePPPower
[fix](Outfile) optimize the error message of SELECT INTO OUTFILE (#…
93269af 
…45859)

optimize the error message of `SELECT INTO OUTFILE`
@github-actions github-actions bot mentioned this pull request Dec 25, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 25, 2024
@BePPPower
[fix](Outfile) optimize the error message of SELECT INTO OUTFILE (#…
7b4b00e 
…45859)

optimize the error message of `SELECT INTO OUTFILE`
@github-actions github-actions bot mentioned this pull request Dec 25, 2024
Merged
morningman pushed a commit that referenced this pull request Dec 25, 2024
@github-actions @BePPPower
branch-3.0: [fix](Outfile) optimize the error message of `SELECT INTO…
7a86c5e 
… OUTFILE` #45859 (#45950)

Cherry-picked from #45859

Co-authored-by: Tiewei Fang <[email protected]>
yiguolei pushed a commit that referenced this pull request Dec 25, 2024
@github-actions @BePPPower
branch-2.1: [fix](Outfile) optimize the error message of `SELECT INTO…
a65adca 
… OUTFILE` #45859 (#45951)

Cherry-picked from #45859

Co-authored-by: Tiewei Fang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@morningman morningman morningman approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BePPPower @hello-stephen @doris-robot @morningman @CalvinKirs @yiguolei