Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement](plugin) logstash: add retry queue without blocking tasks #44999

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[enhancement](plugin) logstash: add retry queue without blocking tasks #44999

wants to merge 8 commits into from
+142 −52

Conversation

joker-star-l
Copy link
Contributor

@joker-star-l joker-star-l commented Dec 4, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

  1. The retry task enters the retry queue separately and no longer blocks the normal queue;
  2. Data quality issues are not retried.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@joker-star-l
Copy link
Contributor Author

run buildall

qidaye
qidaye previously approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

PR approved by anyone and no changes requested.

@joker-star-l
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 10, 2024
@joker-star-l
Copy link
Contributor Author

run buildall

@joker-star-l
Copy link
Contributor Author

run buildall

@joker-star-l
Copy link
Contributor Author

run buildall

qidaye
qidaye previously approved these changes Dec 24, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

xiaokang
xiaokang reviewed Dec 26, 2024
View reviewed changes
extension/logstash/lib/logstash/outputs/doris.rb Outdated Show resolved Hide resolved
extension/logstash/lib/logstash/outputs/doris.rb Show resolved Hide resolved
extension/logstash/lib/logstash/outputs/doris.rb Outdated Show resolved Hide resolved
extension/logstash/lib/logstash/outputs/doris.rb Outdated Show resolved Hide resolved
extension/logstash/lib/logstash/outputs/doris.rb Outdated Show resolved Hide resolved
@joker-star-l
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 27, 2024
xiaokang
xiaokang reviewed Dec 30, 2024
View reviewed changes
extension/logstash/lib/logstash/outputs/doris.rb Outdated Show resolved Hide resolved
extension/logstash/lib/logstash/outputs/doris.rb Outdated Show resolved Hide resolved
extension/logstash/lib/logstash/outputs/doris.rb Outdated
sleep(sleep_rand)
@logger.warn("FAILED doris stream load response:\n#{response}")
# if there are data quality issues, we do not retry
if (status == 'Fail' && response_json['Message'].start_with?("[DATA_QUALITY_ERROR]")) || (@max_retries >= 0 && req_count-1 > @max_retries)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DATA_QUALITY_ERROR should be processed by setting max_filter_ratio instead of hard code here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max_filter_ratio and DATA_QUALITY_ERROR are both needed.

extension/logstash/lib/logstash/outputs/doris.rb
begin
response_json = JSON.parse(response.body)
rescue => _
@logger.warn("doris stream load response is not a valid JSON:\n#{response}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do more exception handling instead of just log warning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If an exception occurs, it will be treated as empty json later.

@joker-star-l
Copy link
Contributor Author

run buildall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaokang xiaokang xiaokang left review comments

@qidaye qidaye qidaye left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joker-star-l @doris-robot @xiaokang @qidaye