Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](meta-service) Avoid rowset meta exceeds 2G result in protobuf fatal #44780

Merged
merged 5 commits into from
Dec 9, 2024
Merged

[fix](meta-service) Avoid rowset meta exceeds 2G result in protobuf fatal #44780

merged 5 commits into from
Dec 9, 2024

Conversation

TangSiyang2001
Copy link
Collaborator

What problem does this PR solve?

Rowset meta may exceed limit of 2GB incase of table of extremely wide variant type. Check the size before serializing.

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@TangSiyang2001
Copy link
Collaborator Author

run buildall

@TangSiyang2001 TangSiyang2001 marked this pull request as ready for review November 29, 2024 09:07
@TangSiyang2001 TangSiyang2001 force-pushed the fix-rowset-meta-too-big branch from 001b254 to ad0bedd Compare November 29, 2024 09:10
@TangSiyang2001
Copy link
Collaborator Author

run buildall

@TangSiyang2001
Copy link
Collaborator Author

run buildall

@TangSiyang2001
Copy link
Collaborator Author

run buildall

@TangSiyang2001
Copy link
Collaborator Author

run buildall

dataroaring
dataroaring approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 8c5307e into apache:master Dec 9, 2024
24 of 25 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 9, 2024
@TangSiyang2001
[fix](meta-service) Avoid rowset meta exceeds 2G result in protobuf f…
b190938 
…atal (#44780)

Rowset meta may exceed limit of 2GB incase of table of extremely wide
variant type. Check the size before serializing.
@github-actions github-actions bot mentioned this pull request Dec 9, 2024
Merged
dataroaring pushed a commit that referenced this pull request Dec 9, 2024
@github-actions @TangSiyang2001
branch-3.0: [fix](meta-service) Avoid rowset meta exceeds 2G result i…
d611e71 
…n protobuf fatal #44780 (#45205)

Cherry-picked from #44780

Co-authored-by: Siyang Tang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou gavinchou approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TangSiyang2001 @doris-robot @gavinchou @dataroaring