Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] (nereids)implement showDataSkewCommand in nereids #42755 #44704

Merged
merged 1 commit into from
Dec 9, 2024
Merged

[Enhancement] (nereids)implement showDataSkewCommand in nereids #42755 #44704

merged 1 commit into from
Dec 9, 2024

Conversation

rijeshkp
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #42755

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@rijeshkp rijeshkp force-pushed the DataSkewCommandToNereids branch 3 times, most recently from 71409b4 to 9f0f713 Compare November 29, 2024 10:37
@rijeshkp rijeshkp marked this pull request as ready for review November 29, 2024 10:49
@LiBinfeng-01
Copy link
Collaborator

run buildall

LiBinfeng-01
LiBinfeng-01 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@LiBinfeng-01 LiBinfeng-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rijeshkp rijeshkp force-pushed the DataSkewCommandToNereids branch 2 times, most recently from 0e29618 to e67f20c Compare December 4, 2024 13:00
@rijeshkp
Copy link
Contributor Author

rijeshkp commented Dec 4, 2024

run buildall

@rijeshkp rijeshkp force-pushed the DataSkewCommandToNereids branch 2 times, most recently from e59d251 to 842bcdc Compare December 5, 2024 12:27
@rijeshkp
Copy link
Contributor Author

rijeshkp commented Dec 5, 2024

run buildall

@rijeshkp rijeshkp force-pushed the DataSkewCommandToNereids branch from 842bcdc to 38653b2 Compare December 5, 2024 13:19
@rijeshkp
Copy link
Contributor Author

rijeshkp commented Dec 5, 2024

run buildall

2 similar comments
@rijeshkp
Copy link
Contributor Author

rijeshkp commented Dec 6, 2024

run buildall

@rijeshkp
Copy link
Contributor Author

rijeshkp commented Dec 6, 2024

run buildall

starocean999
starocean999 previously approved these changes Dec 6, 2024
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

PR approved by anyone and no changes requested.

@rijeshkp rijeshkp force-pushed the DataSkewCommandToNereids branch from 38653b2 to bc25e81 Compare December 9, 2024 03:01
@rijeshkp
Copy link
Contributor Author

rijeshkp commented Dec 9, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 9, 2024
@rijeshkp rijeshkp force-pushed the DataSkewCommandToNereids branch from bc25e81 to 91411c0 Compare December 9, 2024 04:01
@rijeshkp
Copy link
Contributor Author

rijeshkp commented Dec 9, 2024

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

PR approved by at least one committer and no changes requested.

@starocean999 starocean999 merged commit 90cbfc5 into apache:master Dec 9, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiBinfeng-01 LiBinfeng-01 LiBinfeng-01 approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] (nereids)implement showDataSkewCommand in nereids
4 participants
@rijeshkp @doris-robot @LiBinfeng-01 @starocean999