-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](flexible partial update) Fix some problems in flexible partial update #41701
base: master
Are you sure you want to change the base?
[Fix](flexible partial update) Fix some problems in flexible partial update #41701
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
TeamCity be ut coverage result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
24069a4
to
378ef2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
d21f1b1
to
d2e1b4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
6428fa3
to
f177418
Compare
run buildall |
TeamCity be ut coverage result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
run buildall |
TPC-H: Total hot run time: 40999 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 192400 ms
|
ClickBench: Total hot run time: 32.6 s
|
79fe26c
to
02cb8af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
run buildall |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 40756 ms
|
TPC-DS: Total hot run time: 192006 ms
|
ClickBench: Total hot run time: 33.62 s
|
…ict in publish phase
…ockAggregator::aggregate_rows
…ence column may decrease (apache#198) * fix partial update that will cause seq col value not increasing problem * fix flexible partial update that will cause seq col value not increasing problem * fix existing case
… the previous row is deleted in partial update and flexible partial update when doing alignment (apache#206) * only read seq col and seq map col from old rows if old rows if deleted when do alignment for flexible partial update * let partial update only read seq col if the previous row is deleted in flush phase * add flexible partial update publish case * fix partial update publish and add caser
…is not consistent between replicas (apache#207) * add reproduce case * fix and update case * fix auto-increment value not consistent between replicas * add case
c9f2159
to
9cc0eab
Compare
run buildall |
TPC-H: Total hot run time: 32706 ms
|
TPC-DS: Total hot run time: 189531 ms
|
ClickBench: Total hot run time: 30.77 s
|
TeamCity be ut coverage result: |
In the above situation, we should keep those rows and don't merge them when doing aggregation in memtable. When flush the memtable to segment, we should first apply the semantic of delete if exists and then insert the row after it.