diff --git a/be/src/vec/data_types/data_type.h b/be/src/vec/data_types/data_type.h index 6c54241ea18a2a..e193856c05187d 100644 --- a/be/src/vec/data_types/data_type.h +++ b/be/src/vec/data_types/data_type.h @@ -151,16 +151,8 @@ class IDataType : private boost::noncopyable { */ virtual bool is_value_represented_by_number() const { return false; } - /** Integers, Enums, Date, DateTime. Not nullable. - */ - virtual bool is_value_represented_by_integer() const { return false; } - virtual bool is_object() const { return false; } - /** Unsigned Integers, Date, DateTime. Not nullable. - */ - virtual bool is_value_represented_by_unsigned_integer() const { return false; } - /** Values are unambiguously identified by contents of contiguous memory region, * that can be obtained by IColumn::get_data_at method. * Examples: numbers, Date, DateTime, String, FixedString, @@ -386,10 +378,6 @@ inline bool is_not_decimal_but_comparable_to_decimal(const DataTypePtr& data_typ return which.is_int() || which.is_uint(); } -inline bool is_compilable_type(const DataTypePtr& data_type) { - return data_type->is_value_represented_by_number() && !is_decimal(data_type); -} - inline bool is_complex_type(const DataTypePtr& data_type) { WhichDataType which(data_type); return which.is_array() || which.is_map() || which.is_struct(); diff --git a/be/src/vec/data_types/data_type_bitmap.h b/be/src/vec/data_types/data_type_bitmap.h index 24f1e6334431c1..ce0f327f5450a5 100644 --- a/be/src/vec/data_types/data_type_bitmap.h +++ b/be/src/vec/data_types/data_type_bitmap.h @@ -77,9 +77,6 @@ class DataTypeBitMap : public IDataType { bool should_align_right_in_pretty_formats() const override { return false; } bool text_can_contain_only_valid_utf8() const override { return true; } bool is_comparable() const override { return false; } - bool is_value_represented_by_number() const override { return false; } - bool is_value_represented_by_integer() const override { return false; } - bool is_value_represented_by_unsigned_integer() const override { return false; } // TODO: bool is_value_unambiguously_represented_in_contiguous_memory_region() const override { return true; diff --git a/be/src/vec/data_types/data_type_hll.h b/be/src/vec/data_types/data_type_hll.h index 2c4061cf7b4abd..6d8d085a1550f6 100644 --- a/be/src/vec/data_types/data_type_hll.h +++ b/be/src/vec/data_types/data_type_hll.h @@ -69,9 +69,6 @@ class DataTypeHLL : public IDataType { bool should_align_right_in_pretty_formats() const override { return false; } bool text_can_contain_only_valid_utf8() const override { return true; } bool is_comparable() const override { return false; } - bool is_value_represented_by_number() const override { return false; } - bool is_value_represented_by_integer() const override { return false; } - bool is_value_represented_by_unsigned_integer() const override { return false; } // TODO: bool is_value_unambiguously_represented_in_contiguous_memory_region() const override { return true; diff --git a/be/src/vec/data_types/data_type_number_base.cpp b/be/src/vec/data_types/data_type_number_base.cpp index da34d82031cda0..1afed3d7d1a394 100644 --- a/be/src/vec/data_types/data_type_number_base.cpp +++ b/be/src/vec/data_types/data_type_number_base.cpp @@ -313,16 +313,6 @@ MutableColumnPtr DataTypeNumberBase::create_column() const { return ColumnVector::create(); } -template -bool DataTypeNumberBase::is_value_represented_by_integer() const { - return std::is_integral_v; -} - -template -bool DataTypeNumberBase::is_value_represented_by_unsigned_integer() const { - return std::is_integral_v && std::is_unsigned_v; -} - /// Explicit template instantiations - to avoid code bloat in headers. template class DataTypeNumberBase; template class DataTypeNumberBase; diff --git a/be/src/vec/data_types/data_type_number_base.h b/be/src/vec/data_types/data_type_number_base.h index d5ddfe07e831ca..a73bd9951891a3 100644 --- a/be/src/vec/data_types/data_type_number_base.h +++ b/be/src/vec/data_types/data_type_number_base.h @@ -145,8 +145,6 @@ class DataTypeNumberBase : public IDataType { bool text_can_contain_only_valid_utf8() const override { return true; } bool is_comparable() const override { return true; } bool is_value_represented_by_number() const override { return true; } - bool is_value_represented_by_integer() const override; - bool is_value_represented_by_unsigned_integer() const override; bool is_value_unambiguously_represented_in_contiguous_memory_region() const override { return true; } diff --git a/be/src/vec/data_types/data_type_quantilestate.h b/be/src/vec/data_types/data_type_quantilestate.h index 5edfe123dca6df..9d34604395cd0d 100644 --- a/be/src/vec/data_types/data_type_quantilestate.h +++ b/be/src/vec/data_types/data_type_quantilestate.h @@ -72,9 +72,6 @@ class DataTypeQuantileState : public IDataType { bool should_align_right_in_pretty_formats() const override { return false; } bool text_can_contain_only_valid_utf8() const override { return true; } bool is_comparable() const override { return false; } - bool is_value_represented_by_number() const override { return false; } - bool is_value_represented_by_integer() const override { return false; } - bool is_value_represented_by_unsigned_integer() const override { return false; } // TODO: bool is_value_unambiguously_represented_in_contiguous_memory_region() const override { return true;