From 7da0fde9103bdd51f58f3fc62f4ceb6677071b94 Mon Sep 17 00:00:00 2001 From: daidai Date: Thu, 14 Nov 2024 02:03:36 +0800 Subject: [PATCH] fix comment. --- be/src/vec/exec/format/json/new_json_reader.cpp | 3 +-- be/src/vec/exec/format/json/new_json_reader.h | 6 +++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/be/src/vec/exec/format/json/new_json_reader.cpp b/be/src/vec/exec/format/json/new_json_reader.cpp index 4b01c5803852474..c338a6f53985494 100644 --- a/be/src/vec/exec/format/json/new_json_reader.cpp +++ b/be/src/vec/exec/format/json/new_json_reader.cpp @@ -1178,8 +1178,7 @@ Status NewJsonReader::_read_one_message(std::unique_ptr* file_buf, si } // ---------SIMDJSON---------- // simdjson, replace none simdjson function if it is ready -Status NewJsonReader::_simdjson_init_reader(bool is_load) { - _is_load = is_load; +Status NewJsonReader::_simdjson_init_reader() { RETURN_IF_ERROR(_get_range_params()); RETURN_IF_ERROR(_open_file_reader(false)); diff --git a/be/src/vec/exec/format/json/new_json_reader.h b/be/src/vec/exec/format/json/new_json_reader.h index d79aa53479bf8cd..c326c5ef8a8a53c 100644 --- a/be/src/vec/exec/format/json/new_json_reader.h +++ b/be/src/vec/exec/format/json/new_json_reader.h @@ -145,7 +145,7 @@ class NewJsonReader : public GenericReader { Status _read_one_message(std::unique_ptr* file_buf, size_t* read_size); // simdjson, replace none simdjson function if it is ready - Status _simdjson_init_reader(bool is_load); + Status _simdjson_init_reader(); Status _simdjson_parse_json(size_t* size, bool* is_empty_row, bool* eof, simdjson::error_code* error); Status _get_json_value(size_t* size, bool* eof, simdjson::error_code* error, @@ -298,6 +298,10 @@ class NewJsonReader : public GenericReader { int32_t skip_bitmap_col_idx {-1}; bool _is_load = true; + //Used to indicate whether it is a stream load. When loading, only data will be inserted into columnString. + //If an illegal value is encountered during the load process, `_append_error_msg` should be called + //instead of directly returning `Status::DataQualityError` + bool _is_hive_table = false; // In hive : create table xxx ROW FORMAT SERDE 'org.apache.hive.hcatalog.data.JsonSerDe'; // Hive will not allow you to create columns with the same name but different case, including field names inside