Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSIP-74] Optimize workflow-related displays and filters #16631

Open
2 tasks done
Tracked by #14102
sdhzwc opened this issue Sep 19, 2024 · 10 comments
Open
2 tasks done
Tracked by #14102

[DSIP-74] Optimize workflow-related displays and filters #16631

sdhzwc opened this issue Sep 19, 2024 · 10 comments
Assignees
Labels

Comments

@sdhzwc
Copy link
Contributor

sdhzwc commented Sep 19, 2024

Search before asking

  • I had searched in the DSIP and found no similar DSIP.

Motivation

This DSIP involves two main parts, one is to add the creator and modifier field display to be able to clearly determine who is performing the operation. The other is to add filter items to add more customized filters for users. These two parts I intend to realize through two PRs
For problems with more fields and severe small-screen extrusion, columns need to be dynamically displayed and hidden, and this problem is left to other PRs to implement
These are my thoughts, let's see if you agree and I'll work on optimizing them if possible

Design Detail

1、Add creator and modifier fields to display:

Project
	Workflow
		Workflow Timing: createUser、modifyUser
Datasource
	Datasource: createUser、modifyUser
Security
	Tenant Manage: createUser、modifyUser
	User Manage: createUser、modifyUser
	Alarm Group Manage: createUser、modifyUser
	Alarm Instance Manage: createUser、modifyUser
	Worker Group Manage: createUser、modifyUser
	Yarn Queue Manage: createUser、modifyUser
	Environment Manage: createUser、modifyUser
	Cluster Manage: createUser、modifyUser
	K8S Namespace Manage: createUser、modifyUser
	Token Manage: createUser、modifyUser

2、Add customized filters:

Project
	Workflow
		Workflow Definition: status、schedulePublishStatus、createTime
		Workflow Timing: status
Datasource
	Datasource: datasourceType	

Increase the user-friendliness better with the above tweaks

Compatibility, Deprecation, and Migration Plan

Compatibility with latest version.

Test Plan

Test by UT.

Code of Conduct

@sdhzwc sdhzwc added DSIP Waiting for reply Waiting for reply labels Sep 19, 2024
@SbloodyS SbloodyS added discussion discussion and removed Waiting for reply Waiting for reply labels Sep 19, 2024
@SbloodyS
Copy link
Member

SbloodyS commented Sep 19, 2024

I'm +1 on Workflow Definition.

For Workflow Timing, Considering that there are many fields displayed on the page now, adding two more fields is not so necessary, which is not very friendly to users with smaller resolutions. It would be better if there could be a better solution for this piece. For example, add a field option for the user to choose the display field. By default, we only show high priority fields.

@SbloodyS SbloodyS mentioned this issue Sep 19, 2024
77 tasks
@SbloodyS SbloodyS changed the title [DSIP-] optimize workflow-related displays and filters [DSIP-74] optimize workflow-related displays and filters Sep 19, 2024
@sdhzwc
Copy link
Contributor Author

sdhzwc commented Sep 19, 2024

I'm +1 on Workflow Definition.

For Workflow Timing, Considering that there are many fields displayed on the page now, adding two more fields is not so necessary, which is not very friendly to users with smaller resolutions. It would be better if there could be a better solution for this piece. For example, add a field option for the user to choose the display field. By default, we only show high priority fields.

2022411161342846
This program can be a good solution to the problem of many fields, the user can customize the choice of fields to display, you can look at this moving picture

@SbloodyS
Copy link
Member

This program can be a good solution to the problem of many fields, the user can customize the choice of fields to display, > you can look at this moving picture

Yes. That's what I mean.

@sdhzwc
Copy link
Contributor Author

sdhzwc commented Sep 23, 2024

This program can be a good solution to the problem of many fields, the user can customize the choice of fields to display, > you can look at this moving picture

Yes. That's what I mean.

For the optimization points I mentioned above, I make the following adjustments, see below
image
image
But for the column name dynamic display and hide (I am a front-end white, to achieve this for me a bit of a struggle), found that put in a bit out of place feeling, I feel that is not should be a single out of a pr, for the function of the field more than a little optimization of the unity of a little better, I would like to listen to your views?

@SbloodyS
Copy link
Member

But for the column name dynamic display and hide (I am a front-end white, to achieve this for me a bit of a struggle), found > that put in a bit out of place feeling, I feel that is not should be a single out of a pr, for the function of the field more than a > little optimization of the unity of a little better, I would like to listen to your views?

You can just achieve the Workflow Definition part of this issue. And The Workflow Timing part is waiting for other contributors to realize.

@sdhzwc
Copy link
Contributor Author

sdhzwc commented Sep 23, 2024

But for the column name dynamic display and hide (I am a front-end white, to achieve this for me a bit of a struggle), found > that put in a bit out of place feeling, I feel that is not should be a single out of a pr, for the function of the field more than a > little optimization of the unity of a little better, I would like to listen to your views?

You can just achieve the Workflow Definition part of this issue. And The Workflow Timing part is waiting for other contributors to realize.
I'm going to add status filtering and corresponding creator and modifier logic to the workflow timings, can the front-end not show them for now, or are they not necessary?

@sdhzwc
Copy link
Contributor Author

sdhzwc commented Sep 23, 2024

But for the column name dynamic display and hide (I am a front-end white, to achieve this for me a bit of a struggle), found > that put in a bit out of place feeling, I feel that is not should be a single out of a pr, for the function of the field more than a > little optimization of the unity of a little better, I would like to listen to your views?

You can just achieve the Workflow Definition part of this issue. And The Workflow Timing part is waiting for other contributors to realize.

image
I think it's a good idea to add this to these.

@SbloodyS
Copy link
Member

image I think it's a good idea to add this to these.

I think this is unnecessary especially in prod environment.

@sdhzwc
Copy link
Contributor Author

sdhzwc commented Sep 23, 2024

image I think it's a good idea to add this to these.

I think this is unnecessary especially in prod environment.

Okay, then in read more of the other comments, otherwise writing and not passing is the same as not writing at all😂

@SbloodyS SbloodyS changed the title [DSIP-74] optimize workflow-related displays and filters [DSIP-74] Optimize workflow-related displays and filters Sep 23, 2024
@sdhzwc
Copy link
Contributor Author

sdhzwc commented Sep 24, 2024

I've just described the adjustments, take a look, anything else you want to add? @SbloodyS @ruanwenjun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants