Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] [dolphinscheduler-api] LoginHandlerInterceptor.preHandle check session without expire time check #16627

Open
3 tasks done
GOODBOY008 opened this issue Sep 18, 2024 · 4 comments
Open
3 tasks done

[Bug] [dolphinscheduler-api] LoginHandlerInterceptor.preHandle check session without expire time check #16627

GOODBOY008 opened this issue Sep 18, 2024 · 4 comments
Assignees
@SbloodyS
Labels
bug Something isn't working

Comments

@GOODBOY008
Copy link
Member

GOODBOY008 commented Sep 18, 2024 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

LoginHandlerInterceptor.preHandle check session without expire time check.

https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/interceptor/LoginHandlerInterceptor.java#L71-L77

What you expected to happen

LoginHandlerInterceptor.preHandle should check session expire time.

How to reproduce

Login dolphinscheduler and you can always access the web-ui.

Anything else

No response

Version

dev

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@GOODBOY008 GOODBOY008 added bug Something isn't working Waiting for reply Waiting for reply labels Sep 18, 2024
@GOODBOY008
Copy link
Member Author

@ruanwenjun PTAL ,Thank you ~

@SbloodyS
Copy link
Member

SbloodyS commented Sep 19, 2024 •
edited
Loading

Session expired time is 7200 seconds by default. It not a bug.

@SbloodyS SbloodyS added question Further information is requested and removed bug Something isn't working Waiting for reply Waiting for reply labels Sep 19, 2024
@SbloodyS SbloodyS changed the title [Bug] [dolphinscheduler-api] LoginHandlerInterceptor.preHandle check session without expire time check [Question] [dolphinscheduler-api] LoginHandlerInterceptor.preHandle check session without expire time check Sep 19, 2024
@GOODBOY008
Copy link
Member Author

Session expired time is 7200 seconds by default. It not a bug.

@SbloodyS But there is no check session expired logic in LoginHandlerInterceptor . I tried this on my local environment, logged into DS, and was still able to operate DS the next day.

@SbloodyS
Copy link
Member

After a closer look at the dev branch reveals that the bug does exist.

@SbloodyS SbloodyS self-assigned this Sep 19, 2024
@SbloodyS SbloodyS added bug Something isn't working and removed question Further information is requested labels Sep 19, 2024
@SbloodyS SbloodyS changed the title [Question] [dolphinscheduler-api] LoginHandlerInterceptor.preHandle check session without expire time check [Bug] [dolphinscheduler-api] LoginHandlerInterceptor.preHandle check session without expire time check Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SbloodyS SbloodyS

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GOODBOY008 @SbloodyS