Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][WorkflowTiming] Supports multiple timing plans for one workflow #15151

Open
2 of 3 tasks
HanadaLee opened this issue Nov 10, 2023 · 6 comments
Open
2 of 3 tasks
Labels
feature new feature help wanted Extra attention is needed

Comments

@HanadaLee
Copy link

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Currently, a workflow can only use one scheduled task, so why provide a separate timing management tab for workflow timing. In my opinion, workflow and scheduled planning should have a one-to-many relationship.

image

As shown in the figure, after turning on scheduled tasks, you can no longer add scheduled tasks, and clicking on scheduled management only jumps to a list of only one scheduled task.

Since there is only one scheduled task management, wouldn’t it be better to directly use the scheduled task as an attribute of the task definition?

Use case

Due to some special timing designs, one crontab configuration cannot meet timing requirements. We hope to provide multiple crontab timings and multiple start and stop times for a workflow. Now it seems that I can only create multiple identical workflows for this, and I must modify all these identical workflows every time I modify them.

Related issues

No

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@HanadaLee HanadaLee added feature new feature Waiting for reply Waiting for reply labels Nov 10, 2023
@HanadaLee HanadaLee changed the title [Feature][Module Name] Supports multiple timing plans for one workflow [Feature][WorkflowTiming] Supports multiple timing plans for one workflow Nov 10, 2023
@SbloodyS SbloodyS added help wanted Extra attention is needed and removed Waiting for reply Waiting for reply labels Nov 10, 2023
@xjlgod
Copy link
Contributor

xjlgod commented Nov 14, 2023

I'm not very familiar with the front-end. Can you tell me where the relevant front-end code is? No relevant code was found that was disabled after clicking the Timing button.

@HanadaLee
Copy link
Author

I'm not very familiar with the front-end. Can you tell me where the relevant front-end code is? No relevant code was found that was disabled after clicking the Timing button.

Instead of being disabled after clicking timing, the trigger is disabled after setting a timer.
That is to say, the current workflow only allows one timing to be set.

I'm not familiar with front-end code, so I'm sorry that I can't provide assistance in this regard.

@arlendp
Copy link
Contributor

arlendp commented Nov 15, 2023

The relevant file is dolphinscheduler-ui/src/views/projects/workflow/definition/components/table-action.tsx, according to the design of dolphinscheduler, when setting a scheduler no matter schedule state is online or offline, the Timing button will be disabled for it only support one scheduler.

@xjlgod
Copy link
Contributor

xjlgod commented Nov 18, 2023

The relevant file is dolphinscheduler-ui/src/views/projects/workflow/definition/components/table-action.tsx, according to the design of dolphinscheduler, when setting a scheduler no matter schedule state is online or offline, the Timing button will be disabled for it only support one scheduler.

If there is a violation of design theory, does this mean it can only be solved by duplicating the workflow. Or change the scheduled task workflow to allow multiple scheduled tasks to be created in the scheduled task management UI.

@ssquan
Copy link

ssquan commented Aug 8, 2024

The goal is to have the ability to configure multiple Crontab expression within a single workflow. Does my understanding correct? @HanadaLee

@HanadaLee
Copy link
Author

The goal is to have the ability to configure multiple Crontab expression within a single workflow. Does my understanding correct? @HanadaLee

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants