Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "physical-plan: Cast nested group values back to dictionary if necessary" (#12586) #12976

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Backport "physical-plan: Cast nested group values back to dictionary if necessary" (#12586) #12976

merged 1 commit into from
Oct 16, 2024
+175 −13

Conversation

matthewmturner
Copy link
Contributor

@matthewmturner matthewmturner commented Oct 16, 2024 •
edited by alamb
Loading

Which issue does this PR close?

Part of #12813 applies fix from #12586 / #12542

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Physical Expressions label Oct 16, 2024
@Xuanwo Xuanwo mentioned this pull request Oct 16, 2024
Closed
4 tasks
@matthewmturner matthewmturner changed the title Patch for PR 12586 Backport "physical-plan: Cast nested group values back to dictionary if necessary" from #12586 Oct 16, 2024
@matthewmturner matthewmturner changed the title Backport "physical-plan: Cast nested group values back to dictionary if necessary" from #12586 Backport "physical-plan: Cast nested group values back to dictionary if necessary" (#12586) Oct 16, 2024
@matthewmturner
Copy link
Contributor Author

@alamb @Xuanwo FYI

Xuanwo
Xuanwo approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, no conflict. Let's wait CI to be green.

@alamb
Copy link
Contributor

alamb commented Oct 16, 2024

close/reopen to trigger CI

@alamb alamb closed this Oct 16, 2024
@alamb alamb reopened this Oct 16, 2024
@matthewmturner
Copy link
Contributor Author

@alamb FYI i think this is good to go

alamb
alamb approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @matthewmturner

cc @brancz

@alamb alamb merged commit 7fbc134 into apache:branch-42 Oct 16, 2024
44 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
physical-expr Physical Expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewmturner @alamb @Xuanwo