From 7dbf958d833ce905207d51c691d729748dd96969 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Fri, 28 Jun 2024 10:54:21 -0400 Subject: [PATCH 1/3] Minor: fix SQLOptions::with_allow_ddl comments --- datafusion/core/src/execution/context/mod.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datafusion/core/src/execution/context/mod.rs b/datafusion/core/src/execution/context/mod.rs index 9ec0148d9122..f016715dc053 100644 --- a/datafusion/core/src/execution/context/mod.rs +++ b/datafusion/core/src/execution/context/mod.rs @@ -1490,13 +1490,13 @@ impl SQLOptions { Default::default() } - /// Should DML data modification commands (e.g. `INSERT and COPY`) be run? Defaults to `true`. + /// Should DML data definition commands (e.g. `CREATE TABLE` and `COPY`) be run? Defaults to `true`. pub fn with_allow_ddl(mut self, allow: bool) -> Self { self.allow_ddl = allow; self } - /// Should DML data modification commands (e.g. `INSERT and COPY`) be run? Defaults to `true` + /// Should DML data modification commands (e.g. `INSERT` and `COPY`) be run? Defaults to `true` pub fn with_allow_dml(mut self, allow: bool) -> Self { self.allow_dml = allow; self From ccf96676c7603ca87e4f6389407cafbfe8c5c3f8 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Fri, 28 Jun 2024 10:55:54 -0400 Subject: [PATCH 2/3] fix --- datafusion/core/src/execution/context/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datafusion/core/src/execution/context/mod.rs b/datafusion/core/src/execution/context/mod.rs index f016715dc053..4ea93ef901ac 100644 --- a/datafusion/core/src/execution/context/mod.rs +++ b/datafusion/core/src/execution/context/mod.rs @@ -1490,7 +1490,7 @@ impl SQLOptions { Default::default() } - /// Should DML data definition commands (e.g. `CREATE TABLE` and `COPY`) be run? Defaults to `true`. + /// Should DML data definition commands (e.g. `CREATE TABLE`) be run? Defaults to `true`. pub fn with_allow_ddl(mut self, allow: bool) -> Self { self.allow_ddl = allow; self From 776c830ae2c98c4f05241cee2a3257781c7e24eb Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Sun, 30 Jun 2024 06:28:53 -0400 Subject: [PATCH 3/3] Update datafusion/core/src/execution/context/mod.rs Co-authored-by: Jonah Gao --- datafusion/core/src/execution/context/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datafusion/core/src/execution/context/mod.rs b/datafusion/core/src/execution/context/mod.rs index 4ea93ef901ac..012717a007c2 100644 --- a/datafusion/core/src/execution/context/mod.rs +++ b/datafusion/core/src/execution/context/mod.rs @@ -1490,7 +1490,7 @@ impl SQLOptions { Default::default() } - /// Should DML data definition commands (e.g. `CREATE TABLE`) be run? Defaults to `true`. + /// Should DDL data definition commands (e.g. `CREATE TABLE`) be run? Defaults to `true`. pub fn with_allow_ddl(mut self, allow: bool) -> Self { self.allow_ddl = allow; self