Skip to content

async deserialization functions are unintuitive and possibly insecure #3977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
avantgardnerio opened this issue Oct 26, 2022 · 0 comments · Fixed by #3978
Closed

async deserialization functions are unintuitive and possibly insecure #3977

avantgardnerio opened this issue Oct 26, 2022 · 0 comments · Fixed by #3978
Labels
bug Something isn't working

Comments

@avantgardnerio
Copy link
Contributor

Describe the bug

Discussion has highlighted that turning the logical_plan_from_bytes() method async was probably not a great idea. We should revert it, but not break the progress being made on deltalake tables in Ballista.

To Reproduce

No reproduction steps, but it doesn't seem like a feature either.

Expected behavior

The trait should not be async.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert async changes but keep deltalake working spaceandtimefdn/arrow-datafusion
1 participant
@avantgardnerio