Skip to content

Implement some way to self assign tickets without having full edit access to github #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alamb opened this issue May 17, 2021 · 11 comments
Assignees
Labels
development-process Related to development process of DataFusion

Comments

@alamb
Copy link
Contributor

alamb commented May 17, 2021

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

When someone selects an issue to work on in arrow-datafusion there is no good way for them to "assign" the ticket to themselves and they have to resort to comments like "I would like to work on this one" or ask one of the maintainers to assign the ticket to themselves

Describe the solution you'd like
One idea would be a "claim"-bot that let's you self-assign unassigned tickets w/o the need to have full edit permissions

Describe alternatives you've considered
TBD

Additional context
Suggested by @crepererum

@alamb alamb added the development-process Related to development process of DataFusion label May 17, 2021
@msathis
Copy link
Contributor

msathis commented May 21, 2021

Also assigning labels should be allowed

@jorgecarleitao
Copy link
Member

I think that this could work: https://github.com/bdougie/take-action

We just need infra to white list it. I will take this.

@jorgecarleitao jorgecarleitao self-assigned this Jun 1, 2021
@alamb
Copy link
Contributor Author

alamb commented Jun 1, 2021

Thanks @jorgecarleitao - note I think all that is required from infra is not to rely on a third-party action. It is fine if the code lives in the arrow-rs repository

Notice: December 27, 2020: We only allow Actions that are official "Made by GitHub" or local to the Apache org on GitHub, to address a potential security vulnerability. This is an incident-related policy change. We are researching the situation, and the policy may evolve based on what we learn.

https://infra.apache.org/github-actions-secrets.html

Given the license in https://github.com/bdougie/take-action is MIT, I think we could simply copy the action code into the arrow-rs repo and be good 👍

@jorgecarleitao
Copy link
Member

jorgecarleitao commented Jun 1, 2021

They are not enforcing the policy; we just need to request them to open an exception: e.g. here.

I just did it here

To move code, we need an IP clearance process, which is likely more painful.

@alamb
Copy link
Contributor Author

alamb commented Jun 1, 2021

To move code, we need an IP clearance process, which is likely more painful.

I guess I was thinking since it was MIT licensed we did not need additional clearance. I am not an expert in these matters though 🤷

@BohuTANG
Copy link

BohuTANG commented Jun 1, 2021

Hello,

we can consider this bot https://github.com/datafuselabs/fusebots , who has an /assignme command to take the current issue away and then automatically add a community-take label, demo: databendlabs/databend#663 (comment)

@alamb
Copy link
Contributor Author

alamb commented Jun 2, 2021

That sounds like a cool idea @BohuTANG . Thank you

@devinjdangelo
Copy link
Contributor

I believe this has been completed and can be closed. cc @alamb

@crepererum
Copy link
Contributor

@devinjdangelo how does this currently work?

@devinjdangelo
Copy link
Contributor

@devinjdangelo how does this currently work?

@crepererum If you comment "take" on an issue, it will be automatically assigned to you.

Here is the PR that added the functionality #9132

Here is an example of it working #9291 (comment)

@alamb
Copy link
Contributor Author

alamb commented Feb 25, 2024

It's even documented: https://arrow.apache.org/datafusion/contributor-guide/index.html#finding-and-creating-issues-to-work-on

If you want to work on an issue which is not already assigned to someone else and there are no comment indicating that someone is already working on that issue then you can assign the issue to yourself by submitting a single word comment take. This will assign the issue to yourself. However, if you are unable to make progress you should unassign the issue by using the unassign me link at the top of the issue page (and ask for help if are stuck) so that someone else can get involved in the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion
Projects
None yet
Development

No branches or pull requests

6 participants