Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark runs over time using conbench / ursabench #3088

Closed
alamb opened this issue Aug 9, 2022 · 1 comment
Closed

Benchmark runs over time using conbench / ursabench #3088

alamb opened this issue Aug 9, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Aug 9, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We have various benchmarks in datafusion for example Targeted SQL in https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/benches/sql_planner.rs and https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/benches/aggregate_query_sql.rs

There are also some benchmarks for operators that are used as part of other operations, such as https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/benches/merge.rs

We typically run these benchmarks "on demand" but that means we don't have any idea how the benchmark runs vary over time

The rest of the arrow community has a conbench benchmarking tool -- this was introduced to datafusion https://github.com/apache/arrow-datafusion/tree/master/conbench

There are comments on pull requests now like #3062 (comment) that imply we may be able to get runs of the benchmarks on each commit to master and tracked over time.

Describe the solution you'd like
Figure out how to run the datafusion benchmarks regularly and report their results somewhere. Ideally using ursabot / conbench if possible

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered. Ideally w

Additional context
Add any other context or screenshots about the feature request here.

@alamb alamb added the enhancement New feature or request label Aug 9, 2022
@alamb
Copy link
Contributor Author

alamb commented Mar 7, 2023

Filed follw on #5504 with more explicit request

@alamb alamb closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant