extended tests failing on main (External error: query is expected to fail, but actually succeed:)

[alamb]

Describe the bug

extended tests are failing main

An example https://github.com/apache/datafusion/actions/runs/14331563613/job/40168564406

Compiling datafusion-sqllogictest v46.0.1 (/__w/datafusion/datafusion/datafusion/sqllogictest)
    Finished `release-nonlto` profile [optimized] target(s) in 12m 21s
     Running bin/sqllogictests.rs (target/release-nonlto/deps/sqllogictests-4e1c250[877](https://github.com/apache/datafusion/actions/runs/14331563613/job/40168564406#step:5:878)4cd153)
External error: query is expected to fail, but actually succeed:
[SQL] SELECT - 69 FROM tab0 WHERE + - col1 NOT IN ( - + col1, CAST ( + col0 AS INTEGER ), + + ( + + col1 ) / + - 0 * + col0 )
at ../../datafusion-testing/data/sqlite/random/aggregates/slt_good_11.slt:6360

External error: query is expected to fail, but actually succeed:
[SQL] SELECT DISTINCT col1 AS col1 FROM tab0 WHERE NOT + CASE + 87 WHEN col1 THEN col1 ELSE NULL END NOT BETWEEN - col1 / + col1 AND NULL GROUP BY col1 HAVING NOT col1 * 75 IS NOT NULL
at ../../datafusion-testing/data/sqlite/random/groupby/slt_good_12.slt:12141

To Reproduce

You can run extended tests like this:

https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/README.md#running-tests-sqlite

Expected behavior

• This started happening after Add short circuit evaluation for AND and OR #15462 was merged

I am not sure if this is expected or if it is a bug -- we'll have to look at what the test is doing

Additional context

No response

[alamb]

Here is the query https://github.com/apache/datafusion-testing/blob/243047b9dd682be688628539c604daaddfe640f9/data/sqlite/random/aggregates/slt_good_11.slt#L6359-L6361

It may be that now that the code no longer runs the case causing a divide by zero because it was short circuted

[Omega359]

It may be that now that the code no longer runs the case causing a divide by zero because it was short circuted

Hmm. I can confirm that sql passes in Postgresql and Duckdb, both returning -69 (integer/int32)

[Omega359]

If no one gets to this I'll regenerate the sqlite files tonight

[alamb]

Thanks for confirming @Omega359 -- If you remake the files I can approve/merge it quickly !

[alamb]

I made a PR to update the pin on main:

• Update datafusion-testing pin (to fix extended test on main) #15655