Skip to content

Use SpillManager in AggregateExec and SortMergeJoinExec #15374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2010YOUY01 opened this issue Mar 24, 2025 · 1 comment · Fixed by #15405
Closed

Use SpillManager in AggregateExec and SortMergeJoinExec #15374

2010YOUY01 opened this issue Mar 24, 2025 · 1 comment · Fixed by #15405
Assignees
Labels
enhancement New feature or request

Comments

@2010YOUY01
Copy link
Contributor

Is your feature request related to a problem or challenge?

A new interface for spilling intermediate RecordBatches is proposed in #15355, it can be used in aggregate/SMJ's spilling logic.

Describe the solution you'd like

  1. Look for occurrences of the following 3 functions, and replace with the equivalent function in SpillManager
    pub(crate) fn read_spill_as_stream(

    pub(crate) fn spill_record_batches(

    pub fn spill_record_batch_by_size(
  2. Remove (those with pub(crate)) and deprecate (with pub) the above 3 functions

Describe alternatives you've considered

No response

Additional context

No response

@2010YOUY01 2010YOUY01 added the enhancement New feature or request label Mar 24, 2025
@2010YOUY01 2010YOUY01 changed the title Use SpillManager in AggregateExec and `SortMergeJoinExec Use SpillManager in AggregateExec and SortMergeJoinExec Mar 24, 2025
@2010YOUY01
Copy link
Contributor Author

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant