You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I debugged the code and found that the name of AggregateFunctionExpr is constructed in create_aggregate_expr_and_maybe_filter. In this function, debug information is generated for all Expr instances through Expr's SchemaDisplay.
To address this issue, I propose the following solution:
Add a new member sql_name to AggregateFunctionExpr.
Introduce a new method fmt_sql_name() for Expr, similar to schema_name(), and override it in AggregateFunction to generate sql_name.
Modify fmt_as in AggregateExec to output aggr_expr.sql_name instead of aggr_expr.name.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem or challenge?
part of #14914
The output of
AggregateExec
also seems to contain redundant information.Describe the solution you'd like
I debugged the code and found that the name of
AggregateFunctionExpr
is constructed increate_aggregate_expr_and_maybe_filter
. In this function, debug information is generated for allExpr
instances throughExpr
'sSchemaDisplay
.To address this issue, I propose the following solution:
sql_name
toAggregateFunctionExpr
.fmt_sql_name()
forExpr
, similar toschema_name()
, and override it inAggregateFunction
to generatesql_name
.fmt_as
inAggregateExec
to outputaggr_expr.sql_name
instead ofaggr_expr.name
.Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: