You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we can move type coercion into LogicalPlan building stage #14618, I think Union logic is able to be resolved at that time #14380, then we don't need EliminateNestedUnion or EliminateOneUnion anymore.
Is your feature request related to a problem or challenge?
@jayzhan211 removed the
UnwrapCastInComparison
optimizer (and combined it with the simplifier) InUnwrapCastInComparison
intoSimplifier
#15012Doing so seemed to make a non trivial difference for planning speed:
UnwrapCastInComparison
intoSimplifier
#15012 (comment)I think the improvement came from reducing the number of Optimizer passes (and this rewrites/copies of the plan and all expressions) that happened
Here were my mesurements about speed

Describe the solution you'd like
I would like to make planning faster by potentially combining other passes from this list:
datafusion/datafusion/optimizer/src/optimizer.rs
Lines 243 to 272 in 43ecd9b
Describe alternatives you've considered
Some potential candidates to try consolidating:
EliminateNestedUnion
+EliminateOneUnion
EliminateJoin
andEliminateJoin
You can run the planning benchmarks like
Additional context
No response
The text was updated successfully, but these errors were encountered: