Skip to content

Code clean for new datafusion-cli streaming printing logic #14886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhuqi-lucas opened this issue Feb 26, 2025 · 7 comments · May be fixed by #14954 or #15234
Open

Code clean for new datafusion-cli streaming printing logic #14886

zhuqi-lucas opened this issue Feb 26, 2025 · 7 comments · May be fixed by #14954 or #15234
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@zhuqi-lucas
Copy link
Contributor

zhuqi-lucas commented Feb 26, 2025

Is your feature request related to a problem or challenge?

This is a follow-up for:
#14877 (comment)

And we can do some code clean work including:

  1. Add streaming state struct and clean up print batch logic
  2. Remove older logics about max-rows
  3. Add more docs and remove confusing docs
  4. Etc

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@zhuqi-lucas zhuqi-lucas added the enhancement New feature or request label Feb 26, 2025
@zhuqi-lucas zhuqi-lucas changed the title Code clean for new datafusion-cli streaming logic Code clean for new datafusion-cli streaming printing logic Feb 26, 2025
@alamb alamb added the good first issue Good for newcomers label Feb 26, 2025
@alamb
Copy link
Contributor

alamb commented Feb 26, 2025

I think this is a nice first isuse for someone who wants to make the code nicer and it is currently tested and could be handled without deep datafusion knowledge

It does require some non trivial rust / refactoring though so it probably isn't a great one for someone new to rust

@shruti2522
Copy link
Contributor

shruti2522 commented Feb 28, 2025

Hi @zhuqi-lucas , I would like to work on this issue.

@shruti2522
Copy link
Contributor

take

@zhuqi-lucas
Copy link
Contributor Author

Sure @shruti2522 , thanks!

@alamb
Copy link
Contributor

alamb commented Feb 28, 2025

Thanks @shruti2522 -- can't wait to see what you come up with ❤

@THEAYUSHIMISHRA
Copy link

Hi @zhuqi-lucas , I would like to work on this issue

@alamb
Copy link
Contributor

alamb commented Apr 10, 2025

I think the current status is that the code for this feature was somewhat complicated and in fact caused a regression before the last release so we reverted it.

@zhuqi-lucas has made a new PR with some more tests, but the code is still somewhat complex and thus hard to review. Perhaps you can help review / improve that pR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment