-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Code clean for new datafusion-cli streaming printing logic #14886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think this is a nice first isuse for someone who wants to make the code nicer and it is currently tested and could be handled without deep datafusion knowledge It does require some non trivial rust / refactoring though so it probably isn't a great one for someone new to rust |
Hi @zhuqi-lucas , I would like to work on this issue. |
take |
Sure @shruti2522 , thanks! |
Thanks @shruti2522 -- can't wait to see what you come up with ❤ |
Hi @zhuqi-lucas , I would like to work on this issue |
I think the current status is that the code for this feature was somewhat complicated and in fact caused a regression before the last release so we reverted it. @zhuqi-lucas has made a new PR with some more tests, but the code is still somewhat complex and thus hard to review. Perhaps you can help review / improve that pR? |
Is your feature request related to a problem or challenge?
This is a follow-up for:
#14877 (comment)
And we can do some code clean work including:
Describe the solution you'd like
No response
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: