Skip to content

Extended tests are failing on main #14549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alamb opened this issue Feb 7, 2025 · 2 comments · Fixed by #14556
Closed

Extended tests are failing on main #14549

alamb opened this issue Feb 7, 2025 · 2 comments · Fixed by #14556
Labels
bug Something isn't working development-process Related to development process of DataFusion

Comments

@alamb
Copy link
Contributor

alamb commented Feb 7, 2025

Describe the bug

Example: https://github.com/apache/datafusion/actions/runs/13203566677/job/36861234807

External error: query is expected to fail with error:
	(regex) DataFusion error: External error: External error: Arrow error: Divide by zero error
but got error:
	DataFusion error: Arrow error: Divide by zero error
[SQL] SELECT DISTINCT col1 AS col1 FROM tab0 WHERE NOT + CASE + 87 WHEN col1 THEN col1 ELSE NULL END NOT BETWEEN - col1 / + col1 AND NULL GROUP BY col1 HAVING NOT col1 * 75 IS NOT NULL
at ../../datafusion-testing/data/sqlite/random/groupby/slt_good_12.slt:12141

External error: query is expected to fail with error:
	(regex) DataFusion error: External error: External error: Arrow error: Divide by zero error
but got error:
	DataFusion error: Arrow error: Divide by zero error
[SQL] SELECT DISTINCT tab0.col1 FROM tab0 GROUP BY col1 HAVING NULL = + col1 / tab0.col1
at ../../datafusion-testing/data/sqlite/random/groupby/slt_good_7.slt:17941

External error: query is expected to fail with error:
	(regex) DataFusion error: External error: External error: Arrow error: Divide by zero error
but got error:
	DataFusion error: Arrow error: Divide by zero error
[SQL] SELECT ALL ( 19 ) FROM tab0 AS cor0 WHERE NULL BETWEEN + CAST ( + col1 AS INTEGER ) + - - col0 + col2 * - 76 + col1 * - 8 / + col1 * - + col0 / - - col2 AND - col2 + col0 * + + col1 * col2 GROUP BY col2 HAVING NOT ( - ( + ( 44 ) ) ) IS NULL
at ../../datafusion-testing/data/sqlite/random/groupby/slt_good_11.slt:21271

error: test failed, to rerun pass `-p datafusion-sqllogictest --test sqllogictests`

Caused by:
  process didn't exit successfully: `/__w/datafusion/datafusion/target/release-nonlto/deps/sqllogictests-2f94f[911](https://github.com/apache/datafusion/actions/runs/13203566677/job/36861234807#step:5:912)ca12b448 --include-sqlite` (exit status: 1)
Error: Process completed with exit code 1.

To Reproduce

No response

Expected behavior

No response

Additional context

I am pretty sure it was due to #14371

The fix is to update the expected output in datafusion-testing

And then we need to update the pin in datafusion to the latest datafusion-testing pin

@alamb alamb added bug Something isn't working development-process Related to development process of DataFusion labels Feb 7, 2025
@ozankabak
Copy link
Contributor

Extended tests are still failing

@alamb
Copy link
Contributor Author

alamb commented Feb 10, 2025

Extended tests are still failing

Thanks. Yeah it seems they worked for one commit
Image

And then started failing after

I filed

To track this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants