Skip to content

Automate updating sqllogictest updates #14158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #13811
alamb opened this issue Jan 16, 2025 · 4 comments · Fixed by #14290
Closed
Tracked by #13811

Automate updating sqllogictest updates #14158

alamb opened this issue Jan 16, 2025 · 4 comments · Fixed by #14290
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jan 16, 2025

Is your feature request related to a problem or challenge?

Now we have the sqlite test suite running against commits to main (see #13967) we need to make sure it the expected answers easy to update when needed

The first examples comes in #14156 (❤ @avkirilishin ) that fixes a bug so we need to update the sqlite expected results with the correct answer

As @Omega359 says on #14156 (comment) apparently this is hard to do

On the flip side I'm the only one currently that can automatically regenerate the slt files so someone doesn't have to manually fix a few hundred or few thousand test cases (I have hacked up code to do it with a hacked side-branch of the sqllogictest-rs repo to do the generation).

Describe the solution you'd like

I would like a documented way for someone other than @Omega359 to update the expected results :)

Describe alternatives you've considered

No response

Additional context

No response

@Omega359
Copy link
Contributor

@Omega359
Copy link
Contributor

take

@Omega359
Copy link
Contributor

So I have a bit of an issue with this. I don't know how to implement this without pointing to a branch in my fork of sqllogictest-rs. The code in that branch is not appropriate for including in upstream - it's just a solution to this one single issue (getting sqlite tests to run in DF and complete them). Is that acceptable?

@alamb
Copy link
Contributor Author

alamb commented Jan 22, 2025

So I have a bit of an issue with this. I don't know how to implement this without pointing to a branch in my fork of sqllogictest-rs. The code in that branch is not appropriate for including in upstream - it's just a solution to this one single issue (getting sqlite tests to run in DF and complete them). Is that acceptable?

Well, it seems better than not being able to update the tests 😬

If /when it gets too painful to maintain perhaps we can evaluate an alternative?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants