Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the return type of sql_select_to_rex() #14088

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

jonahgao
Copy link
Member

Which issue does this PR close?

N/A

Rationale for this change

sql_select_to_rex() always returns a vector with only one element, so we can simplify its return type from Vec<Expr> to Expr.

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

No, sql_select_to_rex is not a public API.

@github-actions github-actions bot added the sql SQL Planner label Jan 11, 2025
@jonahgao
Copy link
Member Author

Thanks @findepi for the review.

@jonahgao jonahgao merged commit 98e821c into apache:main Jan 13, 2025
25 checks passed
@jonahgao jonahgao deleted the return_type branch January 13, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants