-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix join on arrays of unhashable types and allow hash join on all types supported at run-time #13388
base: main
Are you sure you want to change the base?
Conversation
The `downcast_primitive_array!` macro handles all primitive types and only then delegates to fallbacks. It handles Decimal128 and Decimal256 internally.
43b5fac
to
4961ca6
Compare
One way to do so would be via However, those types don't seem to be supported via
|
The other way to do it is to programatically setup the sqllogictest, as is done for datafusion/datafusion/sqllogictest/src/test_context.rs Lines 84 to 85 in ac79ef3
|
Converting to draft as I think it is waiting on some tests. Please let me know if that isn't right and this is ready for another review |
…es supported at run-time apache#13388 Update can_hash to match currently supported hashes.
4961ca6
to
d1fa0eb
Compare
This change has two aspects
|
Which issue does this PR close?
None
Rationale for this change
fix potential query failure due to incorrect
can_hash
resultWhat changes are included in this PR?
can_hash
compute_hashes
Are these changes tested?
Yes, unit tests.
query-based tests are hard to write -- it is unclear how to construct Union or RunEndEncoded types in SQL
Are there any user-facing changes?
yes