Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coerced_from in functions.rs seems to be missing Utf8View in some cases #13363

Open
Omega359 opened this issue Nov 11, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@Omega359
Copy link
Contributor

Describe the bug

Timestamp(TimeUnit::Nanosecond, None),
:

(
Timestamp(TimeUnit::Nanosecond, None),
Null | Timestamp(_, None) | Date32 | Utf8 | LargeUtf8,
) => Some(type_into.clone()),
(Interval(_), Utf8 | LargeUtf8) => Some(type_into.clone()),
// We can go into a Utf8View from a Utf8 or LargeUtf8
(Utf8View, Utf8 | LargeUtf8 | Null) => Some(type_into.clone()),
// Any type can be coerced into strings
(Utf8 | LargeUtf8, _) => Some(type_into.clone()),

I can't see a reason why right now that timestamp or interval should not be a target for Utf8View. As well, there shouldn't be a reason why any type can't be coerced into Utf8View.

To Reproduce

No response

Expected behavior

Utf8View is supported as a source for coercion for Timestamp and Interval, and as a target for coercion for all types.

Additional context

No response

@Omega359 Omega359 added the bug Something isn't working label Nov 11, 2024
@jayzhan211
Copy link
Contributor

jayzhan211 commented Nov 12, 2024

Instead of maintaining this function, we should change function that rely on coerced_from to TypeSignature::String or similar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants