Fix concat simplifier for Utf8View types
#13346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsaucer
force-pushed
the
bugfix/string_view_concat
branch
from
6c9f13e
to
8bad384
Compare
alamb
changed the title
concat simplifier for Utf8View types
alamb
reviewed
Nov 13, 2024
| @@ -282,15 +293,34 @@ pub fn simplify_concat(args: Vec<Expr>) -> Result<ExprSimplifyResult> { | |||
| let mut new_args = Vec::with_capacity(args.len()); | |||
| let mut contiguous_scalar = "".to_string(); | |||
|
|
|||
| let mut merged_type = DataType::Utf8; | |||
There was a problem hiding this comment.
Rather than re-computing the merged type, could you just call
datafusion/datafusion/functions/src/string/concat.rs
Lines 70 to 71 in 6686e03
And use that type?
alamb
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Thank you @timsaucer -- I have a minor suggestion about how to clean up the code but I don't think it is necessary for merging this PR
|
I’ll apply the suggestion, but out of pocket for a few days. Likely Friday |
|
Converting to a draft so I don't accidentally merge this PR by accident :) |
|
@alamb this is ready for re-review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This addresses one item of #13330
Rationale for this change
Concat simplifier was not correctly combining the return types, so Utf8View was instead getting returned as Utf8, causing a schema failure.
What changes are included in this PR?
When combining schema in simplifier, follows the same rules to set the return type.
Are these changes tested?
Tested in unit tests and with tests in
datafusion-pythonthat identified the problem.Added additional checks in current unit test.
Are there any user-facing changes?
None