Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kurtosis_pop to datafusion-functions-extra and out ofcore #12625

Closed
alamb opened this issue Sep 25, 2024 · 2 comments · Fixed by #12647
Closed

Move kurtosis_pop to datafusion-functions-extra and out ofcore #12625

alamb opened this issue Sep 25, 2024 · 2 comments · Fixed by #12647
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Sep 25, 2024

Is your feature request related to a problem or challenge?

@goldmedal added kurtosis_pop 🙏 in #12273, but we merged it before we got consensus about adding new features in a new function (see discussion on #12254)

However, we are now in a position where there is one seemingly random function, kertosis_pop, without the rest of the functions contemplated by @Weijun-H in #12254

Describe the solution you'd like

I suggest we move the implementation of kertosis_pop from the datafusion core into https://github.com/datafusion-contrib/datafusion-functions-extra

This would both help accelerate datafusion-functions-extra and would keep the core easier to reason about

Describe alternatives you've considered

No response

Additional context

No response

@dharanad
Copy link
Contributor

take

@alamb
Copy link
Contributor Author

alamb commented Sep 28, 2024

Thanks @dharanad and @Weijun-H ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants