I'm happy to take this one. For the uses of OnceLock in statics that currently have an associated getter function, such as ROW_GROUP_METADATA and row_group_metadata in access_plan.rs, would it be better to replace calls to the function with direct access to the static, or just simplify the implementation of the getter function without changing the call sites?

We can direct access to the static data, since it is not a breaking change, changing call sites is fine

take

We can't do that (yet). DataFusion MSRV is 1.76

We can't do that (yet). DataFusion MSRV is 1.76

Oh, I forgot that. Sorry @Rafferty97

MSRV is now 1.78 so we can probably revive this issue

@Rafferty97 I unassigned you but if you are still interested in working on this issue, please feel free to reassign it to yourself.

For anyone else who finds this issue, you can see what is needed in this PR: #11690 but that has bitrotted.

I would suggest just applying the same changes in a new PR

take

Didn't LazyLock become stable in 1.80.0 ? https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html

I just tried to use it in main and it wouldn't compile...