Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mode in Aggregation function #12248

Closed
Tracked by #12254
Weijun-H opened this issue Aug 30, 2024 · 6 comments
Closed
Tracked by #12254

Support mode in Aggregation function #12248

Weijun-H opened this issue Aug 30, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@Weijun-H
Copy link
Member

Weijun-H commented Aug 30, 2024

Is your feature request related to a problem or challenge?

The most frequent value.

Describe the solution you'd like

D SELECT mode(col) FROM VALUES ([1, 2]), ([1, 2]), ([2, 3]) AS tab(col);
┌───────────┐
│ mode(col) │
│  varchar  │
├───────────┤
│ [1, 2]    │
└───────────┘

-- The function returns either 1 or 2, but not 3
> SELECT mode(col) FROM VALUES (1), (1), (2), (2), (3) AS tab(col);
 1

> SELECT mode(col) FROM VALUES (NULL), (NULL) AS tab(col);
 NULL

Describe alternatives you've considered

No response

Additional context

https://duckdb.org/docs/sql/functions/aggregates#modex
https://docs.databricks.com/en/sql/language-manual/functions/mode.html

@dmitrybugakov
Copy link
Contributor

take

@dmitrybugakov
Copy link
Contributor

dmitrybugakov commented Sep 7, 2024

Done for primitive/float types, working on bytes/views.

@alamb
Copy link
Contributor

alamb commented Sep 9, 2024

Given #12357 we may want to move this function to some other repo rather than the core

@alamb
Copy link
Contributor

alamb commented Sep 16, 2024

Suggestion: #12254 (comment)

@dmitrybugakov
Copy link
Contributor

Implemented: mode.rs

@alamb
Copy link
Contributor

alamb commented Sep 25, 2024

We are going to implement these in a different repository so closing this ticket to avoid confusion: #12254 (comment)

@alamb alamb closed this as completed Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants