Skip to content

Improve AccumulatorArgs after transition to all udafs #11725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alamb opened this issue Jul 30, 2024 · 3 comments
Open

Improve AccumulatorArgs after transition to all udafs #11725

alamb opened this issue Jul 30, 2024 · 3 comments

Comments

@alamb
Copy link
Contributor

alamb commented Jul 30, 2024

          The end state in my mind now.
pub struct AccumulatorArgs<'a> {
    /// Keep, this is return type, the name might be quite confusing.
    pub data_type: &'a DataType,

    /// We might only need one of `schema` or `dfschema`. It is likely we keep `dfschema`, since we can get `schema` from it.
    pub schema: &'a Schema,

    pub dfschema: &'a DFSchema,

    /// Keep
    pub ignore_nulls: bool,

    /// Convert to physical sort exprs instead
    pub sort_exprs: &'a [Expr],

    /// Keep
    pub is_reversed: bool,

    /// We might able to get the name from expressions
    pub name: &'a str,

    /// Keep
    pub is_distinct: bool,

    /// Get the type from schema and expressions
    pub input_type: &'a DataType,

    /// Convert to physical expressions
    pub input_exprs: &'a [Expr],
}

Originally posted by @jayzhan211 in #11666 (comment)

@xinlifoobar
Copy link
Contributor

take

@alamb
Copy link
Contributor Author

alamb commented Jul 31, 2024

FYI @jayzhan211

@jayzhan211
Copy link
Contributor

There is #11739 that works on name by @lewiszlw , @xinlifoobar I think you can work on input_types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants