You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem or challenge?
Part of #10453, where we are filling out support for extracting statistics for all data types from parquet files
At the moment, even if statistics are extracted for a different type (like Int32) the PruningPredicate will attempt to cast these values to the correct type:
// cast statistics array to required data type (e.g. parquet
// provides timestamp statistics as "Int64")
let array = arrow::compute::cast(&array, data_type)?;
However, in order to be efficient and ensure the cast kernel doesn't add anything incorrectly, we should be extracting the parquet statistics as the correct Array type directly. It turns out we do not do this yet for several types and those types do not have good (or any) test coverage. We almost missed this in #10711 in @xinlifoobar
Thus, we need to add support and tests for other types
Describe the solution you'd like
Add a new test to arrow_stastics.rs (run this with cargo test --test parquet_exec) with the relevant type
Is your feature request related to a problem or challenge?
Part of #10453, where we are filling out support for extracting statistics for all data types from parquet files
At the moment, even if statistics are extracted for a different type (like
Int32
) the PruningPredicate will attempt to cast these values to the correct type:datafusion/datafusion/core/src/physical_optimizer/pruning.rs
Lines 909 to 911 in acd7106
However, in order to be efficient and ensure the cast kernel doesn't add anything incorrectly, we should be extracting the parquet statistics as the correct Array type directly. It turns out we do not do this yet for several types and those types do not have good (or any) test coverage. We almost missed this in #10711 in @xinlifoobar
Thus, we need to add support and tests for other types
Describe the solution you'd like
cargo test --test parquet_exec
) with the relevant typedatafusion/datafusion/core/src/datasource/physical_plan/parquet/statistics.rs
Lines 61 to 182 in acd7106
Here are some example PRs:
Date32
parquet statistics asDate32Array
rather thanInt32Array
#10593Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: