-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Convert internal representation of LogicalPlanBuilder from LogicalPlan
to Arc<LogicalPlan>
#10485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
good first issue
Good for newcomers
Comments
I think this is a good first issue as it is pretty clear what the ask is |
This was referenced May 13, 2024
take |
iiiancampbell
added a commit
to iiiancampbell/datafusion
that referenced
this issue
May 13, 2024
Converted internal representation of LogicalPlanBuilder from LogicalPlan to Arc<LogicalPlan> apache#10485
Awesome -- thank you @iiiancampbell 🎉 |
iiiancampbell
added a commit
to iiiancampbell/datafusion
that referenced
this issue
May 14, 2024
…lan to Arc<LogicalPlan> apache#10485
I noticed the previous commit is stale and closed. Here is my first attempt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks to @AbrarNitk we have a first version of
LogicalPlanBuilder::from(arc_input)
in #10466 🙏Now that we have merged that PR we can make a second PR (and maybe a second ticket) about switching the internal representation from
datafusion/datafusion/expr/src/logical_plan/builder.rs
Lines 98 to 101 in 8cc92a9
To
The rationale is as explained by @ClSlaid on #10465 (comment) -- that in some cases this can prevent cloning the input
Originally posted by @alamb in #10465 (comment)
The text was updated successfully, but these errors were encountered: