Skip to content

Commit f76c376

Browse files
authored
Merge pull request #1 from alamb/alamb/tweak-group
Do not re-validate output is utf8
2 parents e6c7e7e + 36d556e commit f76c376

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

datafusion/physical-plan/src/aggregates/group_values/group_column.rs

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -592,11 +592,17 @@ impl<B: ByteViewType> ByteViewGroupValueBuilder<B> {
592592

593593
let views = ScalarBuffer::from(views);
594594

595-
Arc::new(GenericByteViewArray::<B>::new(
596-
views,
597-
completed,
598-
null_buffer,
599-
))
595+
// Safety:
596+
// * all views were correctly made
597+
// * (if utf8): Input was valid Utf8 so buffer contents are
598+
// valid utf8 as well
599+
unsafe {
600+
Arc::new(GenericByteViewArray::<B>::new_unchecked(
601+
views,
602+
completed,
603+
null_buffer,
604+
))
605+
}
600606
}
601607

602608
fn take_n_inner(&mut self, n: usize) -> ArrayRef {

0 commit comments

Comments
 (0)