feat: remove box_error_if_needed method and update external_datafusion_err macro to convert input directly to GenericError

Author: Ian Lai

datafusion/common/src/error.rs

@@ -671,20 +671,6 @@ impl DataFusionError {
         queue.push_back(self);
         ErrorIterator { queue }
     }
-
-    /// Converts input to a [`GenericError`],
-    /// handling both regular values and pre-boxed errors to avoid double-boxing.
-    ///
-    /// The input must implement [`Into<GenericError>`], which includes:
-    /// [`Error`] types (implementing `std::error::Error + Send + Sync + 'static`)
-    /// [`String`] and &str (automatically converted to errors)
-    /// [`Box<dyn Error + Send + Sync>`] (passed through without additional boxing)
-    pub fn box_error_if_needed<E>(err: E) -> GenericError
-    where
-        E: Into<GenericError>,
-    {
-        err.into()
-    }
 }
 
 /// A builder for [`DataFusionError`]
@@ -937,9 +923,9 @@ macro_rules! schema_err {
 #[macro_export]
 macro_rules! external_datafusion_err {
     ($CONVERTIBLE_TO_ERR:expr $(; diagnostic = $DIAG:expr)?) => {{
-        let boxed_err = $crate::DataFusionError::box_error_if_needed($CONVERTIBLE_TO_ERR);
         let err = $crate::error::DataFusionError::External(
-            boxed_err,
+            // covert input to GenericError
+            $crate::error::GenericError::from($CONVERTIBLE_TO_ERR),
             Some($crate::error::DataFusionError::get_back_trace())
         );
         $(